From: Yang Weijiang <weijiang.yang@intel.com> To: Sean Christopherson <sean.j.christopherson@intel.com> Cc: Yang Weijiang <weijiang.yang@intel.com>, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, pbonzini@redhat.com, jmattson@google.com, yu.c.zhang@linux.intel.com, alazar@bitdefender.com, edwin.zhai@intel.com Subject: Re: [RESEND PATCH v10 05/10] x86: spp: Introduce user-space SPP IOCTLs Date: Mon, 13 Jan 2020 16:21:32 +0800 Message-ID: <20200113082132.GG12253@local-michael-cet-test.sh.intel.com> (raw) In-Reply-To: <20200110181053.GH21485@linux.intel.com> On Fri, Jan 10, 2020 at 10:10:53AM -0800, Sean Christopherson wrote: > On Thu, Jan 02, 2020 at 02:13:14PM +0800, Yang Weijiang wrote: > > User application, e.g., QEMU or VMI, must initialize SPP > > before gets/sets SPP subpages, the dynamic initialization is to > > reduce the extra storage cost if the SPP feature is not not used. > > > > Co-developed-by: He Chen <he.chen@linux.intel.com> > > Signed-off-by: He Chen <he.chen@linux.intel.com> > > Co-developed-by: Zhang Yi <yi.z.zhang@linux.intel.com> > > Signed-off-by: Zhang Yi <yi.z.zhang@linux.intel.com> > > Signed-off-by: Yang Weijiang <weijiang.yang@intel.com> > > --- > > arch/x86/include/asm/kvm_host.h | 4 ++ > > arch/x86/kvm/mmu/spp.c | 44 +++++++++++++++ > > arch/x86/kvm/mmu/spp.h | 9 ++++ > > arch/x86/kvm/vmx/vmx.c | 15 ++++++ > > arch/x86/kvm/x86.c | 95 ++++++++++++++++++++++++++++++++- > > include/uapi/linux/kvm.h | 3 ++ > > 6 files changed, 169 insertions(+), 1 deletion(-) > > > > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > > index f5145b86d620..c7a9f03f39a7 100644 > > --- a/arch/x86/include/asm/kvm_host.h > > +++ b/arch/x86/include/asm/kvm_host.h > > @@ -1238,6 +1238,10 @@ struct kvm_x86_ops { > > > > bool (*apic_init_signal_blocked)(struct kvm_vcpu *vcpu); > > int (*enable_direct_tlbflush)(struct kvm_vcpu *vcpu); > > + > > + int (*init_spp)(struct kvm *kvm); > > + int (*flush_subpages)(struct kvm *kvm, u64 gfn, u32 npages); > > + int (*get_inst_len)(struct kvm_vcpu *vcpu); > > If this is necessary, which hopefully it isn't, then get_insn_len() to be > consistent with other KVM nomenclature. > Yep, will change it. > A comment for the series overall, it needs a lot of work to properly order > code between patches. E.g. this patch introduces get_inst_len() without > any justification in the changelog and without a user. At best it's > confusing, at worst this series will be impossible to bisect. I'll double check the patch and add more comments on some confusing points. Meanwhile, will re-order some code to make the serial testable, thanks a lot for your careful review!
next prev parent reply index Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-02 6:13 [RESEND PATCH v10 00/10] Enable Sub-Page Write Protection Support Yang Weijiang 2020-01-02 6:13 ` [RESEND PATCH v10 01/10] Documentation: Add EPT based Subpage Protection and related APIs Yang Weijiang 2020-01-02 6:13 ` [RESEND PATCH v10 02/10] vmx: spp: Add control flags for Sub-Page Protection(SPP) Yang Weijiang 2020-01-10 16:58 ` Sean Christopherson 2020-01-13 5:44 ` Yang Weijiang 2020-01-02 6:13 ` [RESEND PATCH v10 03/10] mmu: spp: Add SPP Table setup functions Yang Weijiang 2020-01-10 17:26 ` Sean Christopherson 2020-01-13 6:00 ` Yang Weijiang 2020-01-10 17:40 ` Sean Christopherson 2020-01-13 6:04 ` Yang Weijiang 2020-01-02 6:13 ` [RESEND PATCH v10 04/10] mmu: spp: Add functions to operate SPP access bitmap Yang Weijiang 2020-01-10 17:38 ` Sean Christopherson 2020-01-13 6:15 ` Yang Weijiang 2020-01-02 6:13 ` [RESEND PATCH v10 05/10] x86: spp: Introduce user-space SPP IOCTLs Yang Weijiang 2020-01-10 18:10 ` Sean Christopherson 2020-01-13 8:21 ` Yang Weijiang [this message] 2020-01-02 6:13 ` [RESEND PATCH v10 06/10] vmx: spp: Set up SPP paging table at vmentry/vmexit Yang Weijiang 2020-01-10 17:55 ` Sean Christopherson 2020-01-13 6:50 ` Yang Weijiang 2020-01-21 14:01 ` Paolo Bonzini 2020-01-10 18:04 ` Sean Christopherson 2020-01-13 8:10 ` Yang Weijiang 2020-01-13 17:33 ` Sean Christopherson 2020-01-13 18:55 ` Adalbert Lazăr 2020-01-13 21:47 ` Sean Christopherson 2020-01-14 3:08 ` Yang Weijiang 2020-01-14 18:58 ` Sean Christopherson 2020-01-15 1:36 ` Yang Weijiang 2020-01-21 14:14 ` Paolo Bonzini 2020-01-02 6:13 ` [RESEND PATCH v10 07/10] mmu: spp: Enable Lazy mode SPP protection Yang Weijiang 2020-01-02 6:13 ` [RESEND PATCH v10 08/10] mmu: spp: Handle SPP protected pages when VM memory changes Yang Weijiang 2020-01-02 6:13 ` [RESEND PATCH v10 09/10] x86: spp: Add SPP protection check in emulation Yang Weijiang 2020-01-02 6:13 ` [RESEND PATCH v10 10/10] kvm: selftests: selftest for Sub-Page protection Yang Weijiang -- strict thread matches above, loose matches on Subject: below -- 2020-01-02 5:18 [RESEND PATCH v10 00/10] Enable Sub-Page Write Protection Support Yang Weijiang 2020-01-02 5:18 ` [RESEND PATCH v10 05/10] x86: spp: Introduce user-space SPP IOCTLs Yang Weijiang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200113082132.GG12253@local-michael-cet-test.sh.intel.com \ --to=weijiang.yang@intel.com \ --cc=alazar@bitdefender.com \ --cc=edwin.zhai@intel.com \ --cc=jmattson@google.com \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pbonzini@redhat.com \ --cc=sean.j.christopherson@intel.com \ --cc=yu.c.zhang@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
KVM Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/kvm/0 kvm/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 kvm kvm/ https://lore.kernel.org/kvm \ kvm@vger.kernel.org public-inbox-index kvm Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.kvm AGPL code for this site: git clone https://public-inbox.org/public-inbox.git