From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68F56C33CA9 for ; Mon, 13 Jan 2020 17:21:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 39A3F21556 for ; Mon, 13 Jan 2020 17:21:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ieuvtBxJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728668AbgAMRVZ (ORCPT ); Mon, 13 Jan 2020 12:21:25 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:27707 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727331AbgAMRVY (ORCPT ); Mon, 13 Jan 2020 12:21:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578936083; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0XkcfwbLbTxexmf9zve6b529lGv2sL04AzlNOtnKRyc=; b=ieuvtBxJ1WIRzz4G3h/oc9skPax8P+dWqM17hiMfWMDjZuK6rpn/nGgWkstuyKGT8UrceZ 8LqA2IF7Xhi2xC8aeS+zN4uf8bUT7pyOXTUoYRtorDwKn5738iVPLJResTayniUglA4Kby P7ZwZVsMUrCxfZ5m4LqVeGoTK2JfiDI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-206-Z6U0HnzSMdiwh647B2R61w-1; Mon, 13 Jan 2020 12:21:20 -0500 X-MC-Unique: Z6U0HnzSMdiwh647B2R61w-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E923D10054E3; Mon, 13 Jan 2020 17:21:17 +0000 (UTC) Received: from kamzik.brq.redhat.com (unknown [10.43.2.160]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5F92B60BF1; Mon, 13 Jan 2020 17:21:12 +0000 (UTC) Date: Mon, 13 Jan 2020 18:21:10 +0100 From: Andrew Jones To: Eric Auger Cc: eric.auger.pro@gmail.com, maz@kernel.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, qemu-devel@nongnu.org, qemu-arm@nongnu.org, andre.przywara@arm.com, peter.maydell@linaro.org, yuzenghui@huawei.com, alexandru.elisei@arm.com, thuth@redhat.com Subject: Re: [kvm-unit-tests PATCH v2 06/16] arm/arm64: ITS: Test BASER Message-ID: <20200113172110.27p3bgozit6djf7k@kamzik.brq.redhat.com> References: <20200110145412.14937-1-eric.auger@redhat.com> <20200110145412.14937-7-eric.auger@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200110145412.14937-7-eric.auger@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Jan 10, 2020 at 03:54:02PM +0100, Eric Auger wrote: > Add helper routines to parse and set up BASER registers. > Add a new test dedicated to BASER accesses. > > Signed-off-by: Eric Auger > > --- > > v2 -> v3: > - remove everything related to memory attributes > - s/dev_baser/coll_baser/ in report_info > - add extra line > - removed index filed in its_baser > --- > arm/gic.c | 21 ++++++++++- > arm/unittests.cfg | 6 +++ > lib/arm/asm/gic-v3-its.h | 14 +++++++ > lib/arm/gic-v3-its.c | 80 ++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 120 insertions(+), 1 deletion(-) > > diff --git a/arm/gic.c b/arm/gic.c > index adeb981..3597ac3 100644 > --- a/arm/gic.c > +++ b/arm/gic.c > @@ -531,11 +531,26 @@ static void test_its_introspection(void) > typer->collid_bits); > report(typer->eventid_bits && typer->deviceid_bits && > typer->collid_bits, "ID spaces"); > - report(!typer->hw_collections, "collections only in ext memory"); > report_info("Target address format %s", > typer->pta ? "Redist basse address" : "PE #"); > } > > +static void test_its_baser(void) > +{ > + struct its_baser *dev_baser, *coll_baser; > + > + if (!gicv3_its_base()) { > + report_skip("No ITS, skip ..."); > + return; > + } > + > + dev_baser = its_lookup_baser(GITS_BASER_TYPE_DEVICE); > + coll_baser = its_lookup_baser(GITS_BASER_TYPE_COLLECTION); > + report(dev_baser && coll_baser, "detect device and collection BASER"); > + report_info("device baser entry_size = 0x%x", dev_baser->esz); > + report_info("collection baser entry_size = 0x%x", coll_baser->esz); > +} > + > int main(int argc, char **argv) > { > if (!gic_init()) { > @@ -571,6 +586,10 @@ int main(int argc, char **argv) > report_prefix_push(argv[1]); > test_its_introspection(); > report_prefix_pop(); > + } else if (strcmp(argv[1], "its-baser") == 0) { > + report_prefix_push(argv[1]); > + test_its_baser(); > + report_prefix_pop(); > } else { > report_abort("Unknown subtest '%s'", argv[1]); > } > diff --git a/arm/unittests.cfg b/arm/unittests.cfg > index bd20460..2234a0f 100644 > --- a/arm/unittests.cfg > +++ b/arm/unittests.cfg > @@ -128,6 +128,12 @@ smp = $MAX_SMP > extra_params = -machine gic-version=3 -append 'its-introspection' > groups = its > > +[its-baser] > +file = gic.flat > +smp = $MAX_SMP > +extra_params = -machine gic-version=3 -append 'its-baser' > +groups = its Do these tests need to be run separately from the its-introspection tests for some reason? If not, then I'd combine them. Thanks, drew