From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0735AC33CA9 for ; Mon, 13 Jan 2020 20:11:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D9B6E21744 for ; Mon, 13 Jan 2020 20:11:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728682AbgAMULF (ORCPT ); Mon, 13 Jan 2020 15:11:05 -0500 Received: from mga14.intel.com ([192.55.52.115]:21225 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726878AbgAMULF (ORCPT ); Mon, 13 Jan 2020 15:11:05 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jan 2020 12:11:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,430,1571727600"; d="scan'208";a="218762103" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.202]) by fmsmga007.fm.intel.com with ESMTP; 13 Jan 2020 12:11:04 -0800 Date: Mon, 13 Jan 2020 12:11:04 -0800 From: Sean Christopherson To: linmiaohe Cc: pbonzini@redhat.com, rkrcmar@redhat.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, liran.alon@oracle.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v2] KVM: nVMX: vmread should not set rflags to specify success in case of #PF Message-ID: <20200113201103.GD2322@linux.intel.com> References: <1577514324-18362-1-git-send-email-linmiaohe@huawei.com> <20200113200942.GC2322@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200113200942.GC2322@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Jan 13, 2020 at 12:09:42PM -0800, Sean Christopherson wrote: > On Sat, Dec 28, 2019 at 02:25:24PM +0800, linmiaohe wrote: > > From: Miaohe Lin > > > > In case writing to vmread destination operand result in a #PF, vmread > > should not call nested_vmx_succeed() to set rflags to specify success. > > Similar to as done in VMPTRST (See handle_vmptrst()). > > > > Reviewed-by: Liran Alon > > Signed-off-by: Miaohe Lin > > Reviewed-by: Sean Christopherson Gah, got trigger happy. This could also have "Cc: stable@vger.kernel.org". With that, my Reviewed-by stands :-).