From: Oliver Upton <oupton@google.com>
To: kvm@vger.kernel.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Oliver Upton <oupton@google.com>
Subject: [PATCH 0/3] Handle monitor trap flag during instruction emulation
Date: Mon, 13 Jan 2020 14:10:50 -0800 [thread overview]
Message-ID: <20200113221053.22053-1-oupton@google.com> (raw)
KVM already provides guests the ability to use the 'monitor trap flag'
VM-execution control. Support for this flag is provided by the fact that
KVM unconditionally forwards MTF VM-exits to the guest (if requested),
as KVM doesn't utilize MTF. While this provides support during hardware
instruction execution, it is insufficient for instruction emulation.
Should L0 emulate an instruction on the behalf of L2, L0 should also
synthesize an MTF VM-exit into L1, should control be set.
The first patch fixes the handling of #DB payloads for both Intel and
AMD. To support MTF, KVM must also populate the 'pending debug
exceptions' field, rather than directly manipulating the debug register
state. Additionally, the exception payload associated with #DB is said
to be compatible with the 'pending debug exceptions' field in VMX. This
does not map cleanly into an AMD DR6 register, requiring bit 12 (enabled
breakpoint on Intel, reserved MBZ on AMD) to be masked off.
The second patch implements MTF under instruction emulation by adding
vendor-specific hooks to kvm_skip_emulated_instruction(). Should any
non-debug exception be pending before this call, MTF will follow event
delivery. Otherwise, an MTF VM-exit may be synthesized directly into L1.
Third patch introduces tests to kvm-unit-tests. These tests path both
under virtualization and on bare-metal.
Oliver Upton (2):
KVM: x86: Add vendor-specific #DB payload delivery
KVM: x86: Emulate MTF when performing instruction emulation
arch/x86/include/asm/kvm_host.h | 2 ++
arch/x86/kvm/svm.c | 25 +++++++++++++++++++++
arch/x86/kvm/vmx/nested.c | 2 +-
arch/x86/kvm/vmx/nested.h | 5 +++++
arch/x86/kvm/vmx/vmx.c | 39 ++++++++++++++++++++++++++++++++-
arch/x86/kvm/x86.c | 27 ++++++-----------------
6 files changed, 78 insertions(+), 22 deletions(-)
--
2.25.0.rc1.283.g88dfdc4193-goog
next reply other threads:[~2020-01-13 22:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 22:10 Oliver Upton [this message]
2020-01-13 22:10 ` [PATCH 1/3] KVM: x86: Add vendor-specific #DB payload delivery Oliver Upton
2020-01-13 22:52 ` Sean Christopherson
2020-01-13 23:16 ` Oliver Upton
2020-01-13 23:51 ` Oliver Upton
2020-01-13 22:10 ` [PATCH 2/3] KVM: x86: Emulate MTF when performing instruction emulation Oliver Upton
2020-01-14 0:05 ` Sean Christopherson
2020-01-14 17:58 ` Jim Mattson
2020-01-14 18:28 ` Sean Christopherson
2020-01-17 21:43 ` Jim Mattson
2020-01-15 22:51 ` Oliver Upton
2020-01-21 15:28 ` Paolo Bonzini
2020-01-13 22:10 ` [kvm-unit-tests PATCH 3/3] x86: VMX: Add tests for monitor trap flag Oliver Upton
2020-01-13 22:35 ` [PATCH 0/3] Handle monitor trap flag during instruction emulation Sean Christopherson
2020-01-13 23:06 ` Oliver Upton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113221053.22053-1-oupton@google.com \
--to=oupton@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).