From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FA83C33C9E for ; Tue, 14 Jan 2020 17:32:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 73C262075B for ; Tue, 14 Jan 2020 17:32:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IF22LAu0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728733AbgANRcV (ORCPT ); Tue, 14 Jan 2020 12:32:21 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:37571 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726491AbgANRcV (ORCPT ); Tue, 14 Jan 2020 12:32:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579023140; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2Yz90B8GmMIWzrKxrkLuFNq92zftfc/1no2n+xOhrRY=; b=IF22LAu0H5a9fuU7AU5TuBdBATX+nQiWoQAIIPsTWlIIeEQFLkSXECCvNc7vRx9tia11BV LwDn70+0DPSAdSQEp4+nFhaim7gVIu51HpbL3h0hzizy+F4d6CXuTZFFmw6OJtXZhaeX+I QMgzJMbenP2s8dqk8LVB5quxFr0GArw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-235-B-6O4LwFNdSVUg9mh6oRIA-1; Tue, 14 Jan 2020 12:32:17 -0500 X-MC-Unique: B-6O4LwFNdSVUg9mh6oRIA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B6231800D41; Tue, 14 Jan 2020 17:32:15 +0000 (UTC) Received: from gondolin (ovpn-117-161.ams2.redhat.com [10.36.117.161]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4F4CF5C1D6; Tue, 14 Jan 2020 17:32:14 +0000 (UTC) Date: Tue, 14 Jan 2020 18:32:11 +0100 From: Cornelia Huck To: Janosch Frank Cc: kvm@vger.kernel.org, thuth@redhat.com, borntraeger@de.ibm.com, linux-s390@vger.kernel.org, david@redhat.com Subject: Re: [kvm-unit-tests PATCH 1/4] s390x: smp: Cleanup smp.c Message-ID: <20200114183211.617ecb7e.cohuck@redhat.com> In-Reply-To: <20200114153054.77082-2-frankja@linux.ibm.com> References: <20200114153054.77082-1-frankja@linux.ibm.com> <20200114153054.77082-2-frankja@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, 14 Jan 2020 10:30:50 -0500 Janosch Frank wrote: > Let's remove a lot of badly formatted code by introducing the > wait_for_flag() function. > > Also let's remove some stray spaces. > > Signed-off-by: Janosch Frank > --- > s390x/smp.c | 41 +++++++++++++++++++++++------------------ > 1 file changed, 23 insertions(+), 18 deletions(-) This looks like some nice copy/paste had been going on :) Reviewed-by: Cornelia Huck