From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DF27C33CAA for ; Tue, 21 Jan 2020 14:04:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 742BC24653 for ; Tue, 21 Jan 2020 14:04:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZJE0lCnM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728927AbgAUOEM (ORCPT ); Tue, 21 Jan 2020 09:04:12 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:58506 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728896AbgAUOEM (ORCPT ); Tue, 21 Jan 2020 09:04:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579615451; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1yewETrp0bx5dCOhPi4FrNd4A1wPaHg/+rWGjLZ7t5k=; b=ZJE0lCnMQ7FLZ16YDjNXDPKL13sK29oOloQ43fK9dLTiW3OXgk89KwXsNcZgiPYCu5f9ex lGwRV7/i+mO9GooiTJVb/gEHbyxxLQ+5GTE6yON5nBESyQICe2dJbldiPiqD8XvuoaD5SN UCTWdmlVSRa9UyX/knfx1g32xEv7O94= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-198-Q1TTmX2CM7ifNImeokplPw-1; Tue, 21 Jan 2020 09:04:09 -0500 X-MC-Unique: Q1TTmX2CM7ifNImeokplPw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 82ABD8010D6; Tue, 21 Jan 2020 14:04:07 +0000 (UTC) Received: from gondolin (dhcp-192-195.str.redhat.com [10.33.192.195]) by smtp.corp.redhat.com (Postfix) with ESMTP id 945C08BE1E; Tue, 21 Jan 2020 14:04:00 +0000 (UTC) Date: Tue, 21 Jan 2020 15:03:58 +0100 From: Cornelia Huck To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Cc: qemu-devel@nongnu.org, Peter Maydell , Marcelo Tosatti , David Gibson , qemu-s390x@nongnu.org, David Hildenbrand , qemu-ppc@nongnu.org, Eduardo Habkost , Like Xu , Markus Armbruster , qemu-arm@nongnu.org, Paolo Bonzini , Richard Henderson , Alistair Francis , kvm@vger.kernel.org (open list:Overall KVM CPUs) Subject: Re: [PATCH v2 09/10] accel: Replace current_machine->accelerator by current_accel() wrapper Message-ID: <20200121150358.63e5095b.cohuck@redhat.com> In-Reply-To: <20200121110349.25842-10-philmd@redhat.com> References: <20200121110349.25842-1-philmd@redhat.com> <20200121110349.25842-10-philmd@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, 21 Jan 2020 12:03:48 +0100 Philippe Mathieu-Daud=C3=A9 wrote: > We actually want to access the accelerator, not the machine, so > use the current_accel() wrapper instead. >=20 > Suggested-by: Paolo Bonzini > Reviewed-by: Alistair Francis > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > v2: > - Reworded description > - Remove unused include in arm/kvm64 > --- > accel/kvm/kvm-all.c | 4 ++-- > accel/tcg/tcg-all.c | 2 +- > memory.c | 2 +- > target/arm/kvm64.c | 5 ++--- > target/i386/kvm.c | 2 +- > target/ppc/kvm.c | 2 +- > vl.c | 2 +- > 7 files changed, 9 insertions(+), 10 deletions(-) > diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c > index b5799e62b4..45ede6b6d9 100644 > --- a/target/ppc/kvm.c > +++ b/target/ppc/kvm.c > @@ -258,7 +258,7 @@ static void kvm_get_smmu_info(struct kvm_ppc_smmu_inf= o *info, Error **errp) > =20 > struct ppc_radix_page_info *kvm_get_radix_page_info(void) > { > - KVMState *s =3D KVM_STATE(current_machine->accelerator); > + KVMState *s =3D KVM_STATE(current_accel()); > struct ppc_radix_page_info *radix_page_info; > struct kvm_ppc_rmmu_info rmmu_info; > int i; What about the usage in kvmppc_svm_off()?