From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7F40C35242 for ; Fri, 24 Jan 2020 14:55:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C917F2071A for ; Fri, 24 Jan 2020 14:55:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730287AbgAXOzG (ORCPT ); Fri, 24 Jan 2020 09:55:06 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:5996 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729567AbgAXOzG (ORCPT ); Fri, 24 Jan 2020 09:55:06 -0500 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 00OElged049141 for ; Fri, 24 Jan 2020 09:55:05 -0500 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 2xr1yf9myb-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 24 Jan 2020 09:55:04 -0500 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 24 Jan 2020 14:55:02 -0000 Received: from b06avi18626390.portsmouth.uk.ibm.com (9.149.26.192) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 24 Jan 2020 14:54:59 -0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 00OEs7uY43778436 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 Jan 2020 14:54:07 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E4209A405B; Fri, 24 Jan 2020 14:54:57 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D2E32A4054; Fri, 24 Jan 2020 14:54:57 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Fri, 24 Jan 2020 14:54:57 +0000 (GMT) Received: by tuxmaker.boeblingen.de.ibm.com (Postfix, from userid 4958) id 64D24E0379; Fri, 24 Jan 2020 15:54:57 +0100 (CET) From: Eric Farman To: Cornelia Huck , Halil Pasic Cc: "Jason J . Herne" , Jared Rossi , linux-s390@vger.kernel.org, kvm@vger.kernel.org, Eric Farman Subject: [PATCH v1 0/1] vfio-ccw: Fix interrupt handling for HALT/CLEAR Date: Fri, 24 Jan 2020 15:54:54 +0100 X-Mailer: git-send-email 2.17.1 X-TM-AS-GCONF: 00 x-cbid: 20012414-0012-0000-0000-0000038053B6 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20012414-0013-0000-0000-000021BC9E2C Message-Id: <20200124145455.51181-1-farman@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-01-24_04:2020-01-24,2020-01-24 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=2 phishscore=0 priorityscore=1501 mlxlogscore=999 malwarescore=0 clxscore=1015 mlxscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-2001240124 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Conny, As I mentioned offline, I have been encountering some problems while testing the channel path code. By pure coincidence, I found some really good clues that led me to this proposed fix. I moved this commit to the head of my channel path v2 code, but think maybe it should be sent by itself so it doesn't get lost in that noise. Figure 16-6 in SA22-7832-12 (POPS) goes into great detail of the contents of the irb.cpa based on the other bits in the IRB. Both the existing code and this new patch treates the irb.cpa as valid all the time, even though that table has many many entries where the cpa contents are "unpredictable." Methinks that this is partially how we got into this mess, so maybe I need to write some smarter logic here anyway? Thoughts? (Disclaimer1: I didn't go back and re-read the conversations that were had for the commit I marked in the "Fixes:" tag, but will just to make sure we didn't miss something.) (Disclaimer2: This makes my torturing-of-the-chpids test run quite nicely, but I didn't go back to try some of the other cruel-and-unusual tests at my disposable to ensure this patch doesn't cause any other regressions. That's on today's agenda.) Eric Farman (1): vfio-ccw: Don't free channel programs for unrelated interrupts drivers/s390/cio/vfio_ccw_cp.c | 11 +++++++++-- drivers/s390/cio/vfio_ccw_cp.h | 2 +- drivers/s390/cio/vfio_ccw_drv.c | 4 ++-- 3 files changed, 12 insertions(+), 5 deletions(-) -- 2.17.1