From: Kevin Wolf <kwolf@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
kvm@vger.kernel.org, "Juan Quintela" <quintela@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
"Max Reitz" <mreitz@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Fam Zheng" <fam@euphon.net>,
"Michael Roth" <mdroth@linux.vnet.ibm.com>,
"Vladimir Sementsov-Ogievskiy" <vsementsov@virtuozzo.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
qemu-block@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH 10/10] tests/qemu-iotests/check: Update to match Python 3 interpreter
Date: Thu, 30 Jan 2020 11:58:39 +0100 [thread overview]
Message-ID: <20200130105839.GB6438@linux.fritz.box> (raw)
In-Reply-To: <20200129231402.23384-11-philmd@redhat.com>
Am 30.01.2020 um 00:14 hat Philippe Mathieu-Daudé geschrieben:
> All the iotests Python scripts have been converted to search for
> the Python 3 interpreter. Update the ./check script accordingly.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
> index 2890785a10..2e7d29d570 100755
> --- a/tests/qemu-iotests/check
> +++ b/tests/qemu-iotests/check
> @@ -825,7 +825,7 @@ do
>
> start=$(_wallclock)
>
> - if [ "$(head -n 1 "$source_iotests/$seq")" == "#!/usr/bin/env python" ]; then
> + if [ "$(head -n 1 "$source_iotests/$seq")" == "#!/usr/bin/env python3" ]; then
> if $python_usable; then
> run_command="$PYTHON $seq"
> else
Changing some test cases in patch 2 and only updating ./check now breaks
bisectability.
I'm not sure why you separated patch 2 and 8. I think the easiest way
would be to change all qemu-iotests cases in the same patch and also
update ./check in that patch.
Otherwise, you'd have to change ./check in patch 2 to accept both
versions and could possibly remove the "python" version again here.
Kevin
next prev parent reply other threads:[~2020-01-30 10:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 23:13 [PATCH 00/10] python: Explicit usage of Python 3 Philippe Mathieu-Daudé
2020-01-29 23:13 ` [PATCH 01/10] scripts: " Philippe Mathieu-Daudé
2020-01-29 23:13 ` [PATCH 02/10] tests/qemu-iotests: " Philippe Mathieu-Daudé
2020-01-29 23:13 ` [PATCH 03/10] tests: " Philippe Mathieu-Daudé
2020-01-29 23:13 ` [PATCH 04/10] scripts/minikconf: " Philippe Mathieu-Daudé
2020-01-29 23:13 ` [PATCH 05/10] tests/acceptance: Remove shebang header Philippe Mathieu-Daudé
2020-01-30 14:34 ` Wainer dos Santos Moschetta
2020-01-29 23:13 ` [PATCH 06/10] scripts/tracetool: " Philippe Mathieu-Daudé
2020-01-29 23:13 ` [PATCH 07/10] tests/vm: " Philippe Mathieu-Daudé
2020-01-29 23:14 ` [PATCH 08/10] tests/qemu-iotests: Explicit usage of Python 3 Philippe Mathieu-Daudé
2020-01-29 23:14 ` [PATCH 09/10] scripts: " Philippe Mathieu-Daudé
2020-01-29 23:14 ` [PATCH 10/10] tests/qemu-iotests/check: Update to match Python 3 interpreter Philippe Mathieu-Daudé
2020-01-30 10:58 ` Kevin Wolf [this message]
2020-01-30 13:34 ` Philippe Mathieu-Daudé
2020-01-30 14:02 ` [PATCH 00/10] python: Explicit usage of Python 3 Vladimir Sementsov-Ogievskiy
2020-01-30 15:04 ` Philippe Mathieu-Daudé
2020-01-30 15:29 ` Vladimir Sementsov-Ogievskiy
2020-01-30 16:18 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200130105839.GB6438@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=kvm@vger.kernel.org \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).