From: Andrew Jones <drjones@redhat.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, vkuznets@redhat.com
Subject: Re: [PATCH kvm-unit-tests] x86: provide enabled and disabled variation of the PCID test
Date: Wed, 5 Feb 2020 18:22:05 +0100 [thread overview]
Message-ID: <20200205172205.rcmbddvouynatcq4@kamzik.brq.redhat.com> (raw)
In-Reply-To: <20200205154904.GF4877@linux.intel.com>
On Wed, Feb 05, 2020 at 07:49:04AM -0800, Sean Christopherson wrote:
> On Wed, Feb 05, 2020 at 04:29:40PM +0100, Paolo Bonzini wrote:
> > The PCID test checks for exceptions when PCID=0 or INVPCID=0 in
> > CPUID. Cover that by adding a separate testcase with different
> > CPUID.
> >
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> > x86/unittests.cfg | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/x86/unittests.cfg b/x86/unittests.cfg
> > index aae1523..f2401eb 100644
> > --- a/x86/unittests.cfg
> > +++ b/x86/unittests.cfg
> > @@ -228,7 +228,12 @@ extra_params = --append "10000000 `date +%s`"
> >
> > [pcid]
> > file = pcid.flat
> > -extra_params = -cpu qemu64,+pcid
> > +extra_params = -cpu qemu64,+pcid,+invpcid
> > +arch = x86_64
> > +
> > +[pcid-disabled]
> > +file = pcid.flat
> > +extra_params = -cpu qemu64,-pcid,-invpcid
> > arch = x86_64
>
> Hrm, but "-cpu qemu64,-pcid,+invpcid" is arguably the more interesting test
> from a KVM perspective because of the logic in KVM to hide invpcid if pcid
> isn't supported.
>
> And +pcid,-invpcid is also interesting.
>
> Is there an easy-ish change that can be made to allow iterating over
> multiple CPU configurations for single test case?
>
Just a small change to Paolo's patch
[pcid]
file = pcid.flat
extra_params = -cpu qemu64,+pcid,+invpcid
arch = x86_64
group = pcid
[pcid-disabled]
file = pcid.flat
extra_params = -cpu qemu64,-pcid,-invpcid
arch = x86_64
group = pcid
[pcid-more-interesting]
file = pcid.flat
extra_params = -cpu qemu64,-pcid,+invpcid
arch = x86_64
group = pcid
Then run the group with ./run_tests.sh -g pcid
Thanks,
drew
next prev parent reply other threads:[~2020-02-05 17:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 15:29 [PATCH kvm-unit-tests] x86: provide enabled and disabled variation of the PCID test Paolo Bonzini
2020-02-05 15:49 ` Sean Christopherson
2020-02-05 17:22 ` Andrew Jones [this message]
2020-02-05 17:41 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200205172205.rcmbddvouynatcq4@kamzik.brq.redhat.com \
--to=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).