From: Peter Xu <peterx@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
dinechin@redhat.com, sean.j.christopherson@intel.com,
pbonzini@redhat.com, jasowang@redhat.com, yan.y.zhao@intel.com,
mst@redhat.com, kevin.tian@intel.com, alex.williamson@redhat.com,
dgilbert@redhat.com, vkuznets@redhat.com
Subject: Re: [PATCH 10/14] KVM: selftests: Use a single binary for dirty/clear log test
Date: Wed, 5 Feb 2020 12:39:39 -0500 [thread overview]
Message-ID: <20200205173939.GD378317@xz-x1> (raw)
In-Reply-To: <20200205171109.2a7ufrhiqowkqz6e@kamzik.brq.redhat.com>
On Wed, Feb 05, 2020 at 06:11:09PM +0100, Andrew Jones wrote:
> On Wed, Feb 05, 2020 at 10:46:17AM -0500, Peter Xu wrote:
> > On Wed, Feb 05, 2020 at 10:28:52AM +0100, Andrew Jones wrote:
> > > On Tue, Feb 04, 2020 at 09:58:38PM -0500, Peter Xu wrote:
> > > > Remove the clear_dirty_log test, instead merge it into the existing
> > > > dirty_log_test. It should be cleaner to use this single binary to do
> > > > both tests, also it's a preparation for the upcoming dirty ring test.
> > > >
> > > > The default test will still be the dirty_log test. To run the clear
> > > > dirty log test, we need to specify "-M clear-log".
> > >
> > > How about keeping most of these changes, which nicely clean up the
> > > #ifdefs, but also keeping the separate test, which I think is the
> > > preferred way to organize and execute selftests. We can use argv[0]
> > > to determine which path to take rather than a command line parameter.
> >
> > Hi, Drew,
> >
> > How about we just create a few selftest links that points to the same
> > test binary in Makefile? I'm fine with compiling it for mulitple
> > binaries too, just in case the makefile trick could be even easier.
>
> I think I prefer the binaries. That way they can be selectively moved
> and run elsewhere, i.e. each test is a standalone test.
Sure, will do.
--
Peter Xu
next prev parent reply other threads:[~2020-02-05 17:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 2:50 [PATCH v4 00/14] KVM: Dirty ring interface Peter Xu
2020-02-05 2:50 ` [PATCH v4 01/14] KVM: X86: Change parameter for fast_page_fault tracepoint Peter Xu
2020-02-05 2:50 ` [PATCH v4 02/14] KVM: Cache as_id in kvm_memory_slot Peter Xu
2020-02-05 2:50 ` [PATCH v4 03/14] KVM: X86: Don't track dirty for KVM_SET_[TSS_ADDR|IDENTITY_MAP_ADDR] Peter Xu
2020-02-05 2:58 ` [PATCH 04/14] KVM: Pass in kvm pointer into mark_page_dirty_in_slot() Peter Xu
2020-02-05 2:58 ` [PATCH 05/14] KVM: X86: Implement ring-based dirty memory tracking Peter Xu
2020-02-05 2:58 ` [PATCH 06/14] KVM: Make dirty ring exclusive to dirty bitmap log Peter Xu
2020-02-05 2:58 ` [PATCH 07/14] KVM: Don't allocate dirty bitmap if dirty ring is enabled Peter Xu
2020-02-05 2:58 ` [PATCH 08/14] KVM: selftests: Always clear dirty bitmap after iteration Peter Xu
2020-02-05 2:58 ` [PATCH 09/14] KVM: selftests: Sync uapi/linux/kvm.h to tools/ Peter Xu
2020-02-05 2:58 ` [PATCH 10/14] KVM: selftests: Use a single binary for dirty/clear log test Peter Xu
2020-02-05 9:28 ` Andrew Jones
2020-02-05 15:46 ` Peter Xu
2020-02-05 17:11 ` Andrew Jones
2020-02-05 17:39 ` Peter Xu [this message]
2020-02-06 22:40 ` Peter Xu
2020-02-07 8:31 ` Andrew Jones
2020-02-05 2:58 ` [PATCH 11/14] KVM: selftests: Introduce after_vcpu_run hook for dirty " Peter Xu
2020-02-05 2:58 ` [PATCH 12/14] KVM: selftests: Add dirty ring buffer test Peter Xu
2020-02-05 2:58 ` [PATCH 13/14] KVM: selftests: Let dirty_log_test async for dirty ring test Peter Xu
2020-02-05 9:48 ` Andrew Jones
2020-02-05 15:55 ` Peter Xu
2020-02-05 17:15 ` Andrew Jones
2020-02-05 3:00 ` [PATCH 14/14] KVM: selftests: Add "-c" parameter to dirty log test Peter Xu
2020-03-03 17:33 ` [PATCH v4 00/14] KVM: Dirty ring interface Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200205173939.GD378317@xz-x1 \
--to=peterx@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=dgilbert@redhat.com \
--cc=dinechin@redhat.com \
--cc=drjones@redhat.com \
--cc=jasowang@redhat.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).