From: Andrew Jones <drjones@redhat.com>
To: kvm@vger.kernel.org
Cc: pbonzini@redhat.com, Alexandru Elisei <alexandru.elisei@arm.com>,
Andre Przywara <andre.przywara@arm.com>
Subject: [PULL kvm-unit-tests 05/10] arm64: timer: Make irq_received volatile
Date: Thu, 6 Feb 2020 17:24:29 +0100 [thread overview]
Message-ID: <20200206162434.14624-6-drjones@redhat.com> (raw)
In-Reply-To: <20200206162434.14624-1-drjones@redhat.com>
From: Alexandru Elisei <alexandru.elisei@arm.com>
The irq_received field is modified by the interrupt handler. Make it
volatile so that the compiler doesn't reorder accesses with regard to
the instruction that will be causing the interrupt.
Suggested-by: Andre Przywara <andre.przywara@arm.com>
Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com>
Signed-off-by: Andrew Jones <drjones@redhat.com>
---
arm/timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arm/timer.c b/arm/timer.c
index e758e84855c3..82f891147b35 100644
--- a/arm/timer.c
+++ b/arm/timer.c
@@ -109,7 +109,7 @@ static void write_ptimer_ctl(u64 val)
struct timer_info {
u32 irq;
u32 irq_flags;
- bool irq_received;
+ volatile bool irq_received;
u64 (*read_counter)(void);
u64 (*read_cval)(void);
void (*write_cval)(u64);
--
2.21.1
next prev parent reply other threads:[~2020-02-06 16:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 16:24 [PULL kvm-unit-tests 00/10] arm/arm64: Various fixes Andrew Jones
2020-02-06 16:24 ` [PULL kvm-unit-tests 01/10] Makefile: Use no-stack-protector compiler options Andrew Jones
2020-02-06 16:24 ` [PULL kvm-unit-tests 02/10] arm/arm64: psci: Don't run C code without stack or vectors Andrew Jones
2020-02-06 16:24 ` [PULL kvm-unit-tests 03/10] arm64: timer: Add ISB after register writes Andrew Jones
2020-02-06 16:24 ` [PULL kvm-unit-tests 04/10] arm64: timer: Add ISB before reading the counter value Andrew Jones
2020-02-06 16:24 ` Andrew Jones [this message]
2020-02-06 16:24 ` [PULL kvm-unit-tests 06/10] arm64: timer: EOIR the interrupt after masking the timer Andrew Jones
2020-02-06 16:24 ` [PULL kvm-unit-tests 07/10] arm64: timer: Wait for the GIC to sample timer interrupt state Andrew Jones
2020-02-06 16:24 ` [PULL kvm-unit-tests 08/10] arm64: timer: Check the " Andrew Jones
2020-02-06 16:24 ` [PULL kvm-unit-tests 09/10] arm64: timer: Test behavior when timer disabled or masked Andrew Jones
2020-02-06 16:24 ` [PULL kvm-unit-tests 10/10] arm/arm64: Perform dcache clean + invalidate after turning MMU off Andrew Jones
2020-03-17 12:10 ` [PULL kvm-unit-tests 00/10] arm/arm64: Various fixes Alexandru Elisei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200206162434.14624-6-drjones@redhat.com \
--to=drjones@redhat.com \
--cc=alexandru.elisei@arm.com \
--cc=andre.przywara@arm.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).