From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCB9CC35247 for ; Thu, 6 Feb 2020 16:26:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2AAD214AF for ; Thu, 6 Feb 2020 16:26:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gn4MDNjT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727806AbgBFQ0t (ORCPT ); Thu, 6 Feb 2020 11:26:49 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:24751 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727778AbgBFQ0q (ORCPT ); Thu, 6 Feb 2020 11:26:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581006405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=H3nLSU6aNBKxxlwzEldmN2l97fU6AU4NrctqbL5/r9Q=; b=gn4MDNjTmTpfeJjdxoddze1SdOSY1oYCyvksA+OiIHFL+DUb5toFOXhTyBShhGAej2fba1 e5V1DHJI/gzfarbvX9ImQgl0wQKO4+xqhPjwynhMuwCvjFjM1tpy3vc+d7a5UrWi41fjMW 7lk1IxTLtUFZPsXhaZQPQPyNyH9RQVc= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-337-83kSRIsAOoCVEikocMJ_rg-1; Thu, 06 Feb 2020 11:26:44 -0500 X-MC-Unique: 83kSRIsAOoCVEikocMJ_rg-1 Received: by mail-qv1-f71.google.com with SMTP id u11so4002472qvo.8 for ; Thu, 06 Feb 2020 08:26:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=H3nLSU6aNBKxxlwzEldmN2l97fU6AU4NrctqbL5/r9Q=; b=abkxMrt6jYO5ovT9J+MyfF9VxEp2ysibTsXyCsyWP3uHzhUHCj8yMBjwqQ2LgZ41OO i7r889b4/RUvTMQVIUMU7aiJH8HTMz8oWTMVh4afPtCDtlUk7ZBbk7bfNnQCn1fWSzhY cXyDpgi9c7q3gOgXP1L2J2uFbGWx6oL8dUEZJkGmkPJ/mdaio8TiWFJUPm7TsYvEPtl1 MZ5yD31OG+11KIluqYK5UWTaKOgVx3F6kAWPi8hc9IC1VVpFzpxZapVN+bMDkoDAe762 t88yL497aLKKCfAqhyVx+ni7XyFPivxs3Gc8Ov9iC/ent0/WB7Q440cZQcU5gMwn5Fe/ N/kQ== X-Gm-Message-State: APjAAAVkkQwxVmIeSosZ900anyBNe0U74+BXXtMn9e/8BNAvDGjhCuv1 sujDJygEA6WtRVE1lDQ3AlBliD7x4t7PExc1W5vUYiPSf1kkjglhZ+JU8UMH5Hch/EgHEqaB1Bb yt+hfCVvnqF3F X-Received: by 2002:ac8:1e08:: with SMTP id n8mr3297381qtl.175.1581006403785; Thu, 06 Feb 2020 08:26:43 -0800 (PST) X-Google-Smtp-Source: APXvYqxQlIJcJ9283T0k3SJBUCagGgD/4X0S4VFGYxAKtPxVCA909nX5ytULcXgwNYLmQcG3Ogy1yQ== X-Received: by 2002:ac8:1e08:: with SMTP id n8mr3297351qtl.175.1581006403586; Thu, 06 Feb 2020 08:26:43 -0800 (PST) Received: from xz-x1 ([2607:9880:19c8:32::2]) by smtp.gmail.com with ESMTPSA id q7sm1618375qkc.43.2020.02.06.08.26.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2020 08:26:42 -0800 (PST) Date: Thu, 6 Feb 2020 11:26:39 -0500 From: Peter Xu To: Sean Christopherson Cc: Paolo Bonzini , Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, Christoffer Dall , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH v5 10/19] KVM: Drop "const" attribute from old memslot in commit_memory_region() Message-ID: <20200206162639.GC695333@xz-x1> References: <20200121223157.15263-1-sean.j.christopherson@intel.com> <20200121223157.15263-11-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200121223157.15263-11-sean.j.christopherson@intel.com> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Jan 21, 2020 at 02:31:48PM -0800, Sean Christopherson wrote: > Drop the "const" attribute from @old in kvm_arch_commit_memory_region() > to allow arch specific code to free arch specific resources in the old > memslot without having to cast away the attribute. Freeing resources in > kvm_arch_commit_memory_region() paves the way for simplifying > kvm_free_memslot() by eliminating the last usage of its @dont param. > > Signed-off-by: Sean Christopherson Reviewed-by: Peter Xu -- Peter Xu