From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E240C352A2 for ; Thu, 6 Feb 2020 21:24:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4386A21741 for ; Thu, 6 Feb 2020 21:24:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="P8d02Ph+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727767AbgBFVYj (ORCPT ); Thu, 6 Feb 2020 16:24:39 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:51629 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727519AbgBFVYj (ORCPT ); Thu, 6 Feb 2020 16:24:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581024277; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mpppjCJmC0FyN5SMr7bSEAaCj98EBVmwQP8+IcdCU94=; b=P8d02Ph+LnLRpaB0yMM3aJBxMYy1FsnmZyD8D0aigINYNL/pAqcQJdX0Ce1aCKbJf4yIC9 Uo5dyz1B55y6hsL3gSfecgRBuWanIDfOA1EvjXdlFJ318vMnLGk952pebgV1NVTmYRDCB8 0KhVbVTUDNlrbBOa+JfSQ9Tf2iUoHyI= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-129-YTFDyCGbMoyILQ1vLJR8hA-1; Thu, 06 Feb 2020 16:24:35 -0500 X-MC-Unique: YTFDyCGbMoyILQ1vLJR8hA-1 Received: by mail-qt1-f197.google.com with SMTP id k27so138100qtu.12 for ; Thu, 06 Feb 2020 13:24:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mpppjCJmC0FyN5SMr7bSEAaCj98EBVmwQP8+IcdCU94=; b=XXifLJIrMPVjiMq4MDGbKaimQIJWuxgI3wIxcfmWWdgw4HffF4IU4iMvqT8HxgKXuL d+f9ZnbLgiWYLyjniYZmCS87+zZOu+q2EnZlaqfUoCNbkjYi60xsvWDH+maR1aqASKb2 G8KDsOHXNlm8ZqiqTe1jnPeQbL3Nu0vbEPPeUgjHxdIoY2v1oMrZEJMzK1813U0FzLhV nl9f/Zu6htECzTNR3hm7USlcKnTaleDuudWpNWduX3IuWSVQ3OENBLr0P/i1kHv4+4Kf x+7j/gVbnEY3iXrM2eeI9aRyHCC3CrBc3EN1oM/jLCIh6W5T1ojNKIGWgndk2Oyzb8dq dTXA== X-Gm-Message-State: APjAAAUTU70RGMtI3qtQMr3AEITSYrAHsIvEPUPL78kJewGXvuDqmb2m Esr5rjRIeXa+aCCGCgD+9mMJESuf8pbXG+7R/bE1RJj9K71XLVB/xwWW3pJxdaT2HRNoVRmuDEm 1fXkVNUreUr1d X-Received: by 2002:ae9:ebd8:: with SMTP id b207mr4579991qkg.353.1581024275409; Thu, 06 Feb 2020 13:24:35 -0800 (PST) X-Google-Smtp-Source: APXvYqz5VOLMiLzF1LhwmvuD3bg8z0IeFMhpmxCeKGC9RcbBKEXcR3SRyFUKynAlxMw185+NrKLCqw== X-Received: by 2002:ae9:ebd8:: with SMTP id b207mr4579963qkg.353.1581024275206; Thu, 06 Feb 2020 13:24:35 -0800 (PST) Received: from xz-x1 ([2607:9880:19c8:32::2]) by smtp.gmail.com with ESMTPSA id v78sm278695qkb.48.2020.02.06.13.24.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2020 13:24:34 -0800 (PST) Date: Thu, 6 Feb 2020 16:24:31 -0500 From: Peter Xu To: Sean Christopherson Cc: Paolo Bonzini , Paul Mackerras , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Marc Zyngier , James Morse , Julien Thierry , Suzuki K Poulose , linux-mips@vger.kernel.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, Christoffer Dall , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH v5 15/19] KVM: Provide common implementation for generic dirty log functions Message-ID: <20200206212431.GF700495@xz-x1> References: <20200121223157.15263-1-sean.j.christopherson@intel.com> <20200121223157.15263-16-sean.j.christopherson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200121223157.15263-16-sean.j.christopherson@intel.com> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Jan 21, 2020 at 02:31:53PM -0800, Sean Christopherson wrote: [...] > @@ -1333,6 +1369,7 @@ int kvm_clear_dirty_log_protect(struct kvm *kvm, > unsigned long i, n; > unsigned long *dirty_bitmap; > unsigned long *dirty_bitmap_buffer; > + bool flush; > > as_id = log->slot >> 16; > id = (u16)log->slot; > @@ -1356,7 +1393,9 @@ int kvm_clear_dirty_log_protect(struct kvm *kvm, > (log->num_pages < memslot->npages - log->first_page && (log->num_pages & 63))) > return -EINVAL; > > - *flush = false; > + kvm_arch_sync_dirty_log(kvm, memslot); Do we need this even for clear dirty log? > + > + flush = false; > dirty_bitmap_buffer = kvm_second_dirty_bitmap(memslot); > if (copy_from_user(dirty_bitmap_buffer, log->dirty_bitmap, n)) > return -EFAULT; -- Peter Xu