From: Yan Zhao <yan.y.zhao@intel.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 0/3] vfio/type1: Reduce vfio_iommu.lock contention
Date: Wed, 19 Feb 2020 23:38:35 -0500 [thread overview]
Message-ID: <20200220043835.GB30338@joy-OptiPlex-7040> (raw)
In-Reply-To: <20200219135247.42d18bb2@w520.home>
On Thu, Feb 20, 2020 at 04:52:47AM +0800, Alex Williamson wrote:
> On Wed, 19 Feb 2020 04:04:17 -0500
> Yan Zhao <yan.y.zhao@intel.com> wrote:
>
> > On Fri, Jan 17, 2020 at 09:10:51AM +0800, Yan Zhao wrote:
> > > Thank you, Alex!
> > > I'll try it and let you know the result soon. :)
> > >
> > > On Fri, Jan 17, 2020 at 02:17:49AM +0800, Alex Williamson wrote:
> > > > Hi Yan,
> > > >
> > > > I wonder if this might reduce the lock contention you're seeing in the
> > > > vfio_dma_rw series. These are only compile tested on my end, so I hope
> > > > they're not too broken to test. Thanks,
> > > >
> > > > Alex
> > > >
> > > > ---
> > > >
> > > > Alex Williamson (3):
> > > > vfio/type1: Convert vfio_iommu.lock from mutex to rwsem
> > > > vfio/type1: Replace obvious read lock instances
> > > > vfio/type1: Introduce pfn_list mutex
> > > >
> > > >
> > > > drivers/vfio/vfio_iommu_type1.c | 67 ++++++++++++++++++++++++---------------
> > > > 1 file changed, 41 insertions(+), 26 deletions(-)
> > > >
> >
> > hi Alex
> > I have finished testing of this series.
> > It's quite stable and passed our MTBF testing :)
> >
> > However, after comparing the performance data obtained from several
> > benchmarks in guests (see below),
> > it seems that this series does not bring in obvious benefit.
> > (at least to cases we have tested, and though I cannot fully explain it yet).
> > So, do you think it's good for me not to include this series into my next
> > version of "use vfio_dma_rw to read/write IOVAs from CPU side"?
>
> Yes, I would not include it in your series. No reason to bloat your
> series for a feature that doesn't clearly show an improvement. Thanks
> for the additional testing, we can revive them if this lock ever
> resurfaces. I'm was actually more hopeful that holding an external
> group reference might provide a better performance improvement, the
> lookup on every vfio_dma_rw is not very efficient. Thanks,
>
got it. thanks~
Yan
prev parent reply other threads:[~2020-02-20 4:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 18:17 [RFC PATCH 0/3] vfio/type1: Reduce vfio_iommu.lock contention Alex Williamson
2020-01-16 18:17 ` [RFC PATCH 1/3] vfio/type1: Convert vfio_iommu.lock from mutex to rwsem Alex Williamson
2020-01-16 18:18 ` [RFC PATCH 2/3] vfio/type1: Replace obvious read lock instances Alex Williamson
2020-01-16 18:18 ` [RFC PATCH 3/3] vfio/type1: Introduce pfn_list mutex Alex Williamson
2020-01-17 1:10 ` [RFC PATCH 0/3] vfio/type1: Reduce vfio_iommu.lock contention Yan Zhao
2020-02-19 9:04 ` Yan Zhao
2020-02-19 20:52 ` Alex Williamson
2020-02-20 4:38 ` Yan Zhao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220043835.GB30338@joy-OptiPlex-7040 \
--to=yan.y.zhao@intel.com \
--cc=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).