From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EB16C35DE1 for ; Tue, 25 Feb 2020 13:57:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7058724685 for ; Tue, 25 Feb 2020 13:57:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="O+XLYenn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730540AbgBYN53 (ORCPT ); Tue, 25 Feb 2020 08:57:29 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:59446 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725788AbgBYN53 (ORCPT ); Tue, 25 Feb 2020 08:57:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582639048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7u5oyKfwsQp27bsa1IAdlRDT3QgLdAO2qyRAcmzr55s=; b=O+XLYenn4TAA/vBnZQYKFmarxIUjPp+RCV1vbUEwFcYy0PIoOa9PsL30dFStUAfS3LsTKz q0HSRLuxORvO+dygZVZYzWpDCMvNxI6lt7ns6E8UkUsmj7tpBO6f6bTWUnY63iNlJnEaWo KewKstdc/HfrzCnPfh1o+igTGzRIVms= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-430-yqzhWlsOPaSQZmysm31UDA-1; Tue, 25 Feb 2020 08:57:24 -0500 X-MC-Unique: yqzhWlsOPaSQZmysm31UDA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3D649477; Tue, 25 Feb 2020 13:57:21 +0000 (UTC) Received: from localhost (unknown [10.43.2.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6582F65E80; Tue, 25 Feb 2020 13:57:14 +0000 (UTC) Date: Tue, 25 Feb 2020 14:57:12 +0100 From: Igor Mammedov To: Dongjiu Geng Cc: , , , , , , , , , , , , , , , , Subject: Re: [PATCH v24 04/10] ACPI: Build related register address fields via hardware error fw_cfg blob Message-ID: <20200225145712.4dd410d2@redhat.com> In-Reply-To: <20200225094804.3ae51b86@redhat.com> References: <20200217131248.28273-1-gengdongjiu@huawei.com> <20200217131248.28273-5-gengdongjiu@huawei.com> <20200225094804.3ae51b86@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, 25 Feb 2020 09:48:04 +0100 Igor Mammedov wrote: > On Mon, 17 Feb 2020 21:12:42 +0800 > Dongjiu Geng wrote: > > > This patch builds error_block_address and read_ack_register fields > > in hardware errors table , the error_block_address points to Generic > > Error Status Block(GESB) via bios_linker. The max size for one GESB > > is 1kb in bytes, For more detailed information, please refer to > > s/1kb in bytes/1Kb/ > > > document: docs/specs/acpi_hest_ghes.rst > > > > Now we only support one Error source, if necessary, we can extend to > > support more. > > > > Suggested-by: Laszlo Ersek > > Signed-off-by: Dongjiu Geng > > Signed-off-by: Xiang Zheng > > Reviewed-by: Jonathan Cameron > > --- > On the second glance, [...] > > diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c > > index bd5f771..6819fcf 100644 > > --- a/hw/arm/virt-acpi-build.c > > +++ b/hw/arm/virt-acpi-build.c > > @@ -48,6 +48,7 @@ > > #include "sysemu/reset.h" > > #include "kvm_arm.h" > > #include "migration/vmstate.h" > > +#include "hw/acpi/ghes.h" > > > > #define ARM_SPI_BASE 32 > > > > @@ -830,6 +831,11 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuildTables *tables) > > acpi_add_table(table_offsets, tables_blob); > > build_spcr(tables_blob, tables->linker, vms); > > > > + if (vms->ras) { > > + acpi_add_table(table_offsets, tables_blob); that doesn't look right, it's for tables that should be referenced from XSDT > > + build_ghes_error_table(tables->hardware_errors, tables->linker); but this table isn't pointed by XSDT directly. I suggest to move acpi_add_table() to the patch that adds acpi_build_hest() > > + } > > + > > if (ms->numa_state->num_nodes > 0) { > > acpi_add_table(table_offsets, tables_blob); > > build_srat(tables_blob, tables->linker, vms); [...]