From: morbo@google.com
To: kvm@vger.kernel.org
Cc: pbonzini@redhat.com, Bill Wendling <morbo@google.com>
Subject: [kvm-unit-tests PATCH 2/7] pci: use uint32_t for unsigned long values
Date: Tue, 25 Feb 2020 23:44:22 -0800 [thread overview]
Message-ID: <20200226074427.169684-3-morbo@google.com> (raw)
In-Reply-To: <20200226074427.169684-1-morbo@google.com>
From: Bill Wendling <morbo@google.com>
The "pci_bar_*" functions use 64-bit masks, but the results are assigned
to 32-bit variables. Use 32-bit masks, since we're interested only in
the least significant 4-bits.
Signed-off-by: Bill Wendling <morbo@google.com>
---
lib/linux/pci_regs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/linux/pci_regs.h b/lib/linux/pci_regs.h
index 1becea8..3bc2b92 100644
--- a/lib/linux/pci_regs.h
+++ b/lib/linux/pci_regs.h
@@ -96,8 +96,8 @@
#define PCI_BASE_ADDRESS_MEM_TYPE_1M 0x02 /* Below 1M [obsolete] */
#define PCI_BASE_ADDRESS_MEM_TYPE_64 0x04 /* 64 bit address */
#define PCI_BASE_ADDRESS_MEM_PREFETCH 0x08 /* prefetchable? */
-#define PCI_BASE_ADDRESS_MEM_MASK (~0x0fUL)
-#define PCI_BASE_ADDRESS_IO_MASK (~0x03UL)
+#define PCI_BASE_ADDRESS_MEM_MASK (~0x0fU)
+#define PCI_BASE_ADDRESS_IO_MASK (~0x03U)
/* bit 1 is reserved if address_space = 1 */
/* Header type 0 (normal devices) */
--
2.25.0.265.gbab2e86ba0-goog
next prev parent reply other threads:[~2020-02-26 7:45 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 7:44 [kvm-unit-tests PATCH 0/7] Fixes for clang builds morbo
2020-02-26 7:44 ` [kvm-unit-tests PATCH 1/7] x86: emulator: use "SSE2" for the target morbo
2020-02-26 7:44 ` morbo [this message]
2020-02-26 7:59 ` [kvm-unit-tests PATCH 2/7] pci: use uint32_t for unsigned long values Andrew Jones
2020-02-26 9:02 ` Bill Wendling
2020-02-26 9:24 ` Andrew Jones
2020-02-26 7:44 ` [kvm-unit-tests PATCH 3/7] x86: realmode: syscall: add explicit size suffix to ambiguous instructions morbo
2020-02-26 7:44 ` [kvm-unit-tests PATCH 4/7] svm: change operand to output-only for matching constraint morbo
2020-02-26 7:44 ` [kvm-unit-tests PATCH 5/7] svm: convert neg shift to unsigned shift morbo
2020-02-26 7:44 ` [kvm-unit-tests PATCH 6/7] x86: VMX: use inline asm to get stack pointer morbo
2020-02-26 7:44 ` [kvm-unit-tests PATCH 7/7] x86: VMX: the "noclone" attribute is gcc-specific morbo
2020-02-26 8:21 ` Oliver Upton
2020-02-26 8:22 ` Oliver Upton
2020-02-26 9:44 ` [kvm-unit-tests PATCH v2 0/7] Fixes for clang builds Bill Wendling
2020-02-26 9:44 ` [kvm-unit-tests PATCH 1/7] x86: emulator: use "SSE2" for the target Bill Wendling
2020-02-26 9:44 ` [kvm-unit-tests PATCH v2 1/7] x86: pmu: Test WRMSR on a running counter Bill Wendling
2020-02-26 9:44 ` [kvm-unit-tests PATCH 2/7] pci: use uint32_t for unsigned long values Bill Wendling
2020-02-28 11:04 ` Paolo Bonzini
2020-02-28 12:46 ` Andrew Jones
2020-02-28 13:02 ` Paolo Bonzini
2020-02-26 9:44 ` [kvm-unit-tests PATCH v2 2/7] x86: provide enabled and disabled variation of the PCID test Bill Wendling
2020-02-26 9:44 ` [kvm-unit-tests PATCH v2 3/7] x86: pmu: Test perfctr overflow after WRMSR on a running counter Bill Wendling
2020-02-26 9:44 ` [kvm-unit-tests PATCH 3/7] x86: realmode: syscall: add explicit size suffix to ambiguous instructions Bill Wendling
2020-02-26 9:44 ` [kvm-unit-tests PATCH 4/7] svm: change operand to output-only for matching constraint Bill Wendling
2020-02-26 9:44 ` [kvm-unit-tests PATCH v2 4/7] vmx: tweak XFAILS for #DB test Bill Wendling
2020-02-26 9:44 ` [kvm-unit-tests PATCH 5/7] svm: convert neg shift to unsigned shift Bill Wendling
2020-02-28 11:12 ` Paolo Bonzini
2020-02-26 9:44 ` [kvm-unit-tests PATCH v2 5/7] x86: VMX: Add tests for monitor trap flag Bill Wendling
2020-02-26 9:44 ` [kvm-unit-tests PATCH v2 6/7] x86: emulator: use "SSE2" for the target Bill Wendling
2020-02-26 9:44 ` [kvm-unit-tests PATCH 6/7] x86: VMX: use inline asm to get stack pointer Bill Wendling
2020-02-26 9:44 ` [kvm-unit-tests PATCH v2 7/7] pci: cast masks to uint32_t for unsigned long values Bill Wendling
2020-02-26 9:44 ` [kvm-unit-tests PATCH 7/7] x86: VMX: the "noclone" attribute is gcc-specific Bill Wendling
2020-02-28 11:16 ` Paolo Bonzini
2020-02-28 18:19 ` Oliver Upton
2020-02-28 18:24 ` Paolo Bonzini
2020-02-28 18:40 ` Oliver Upton
2020-02-26 19:02 ` [kvm-unit-tests PATCH v2 0/7] Fixes for clang builds Oliver Upton
2020-02-26 20:12 ` [kvm-unit-tests PATCH v3 " Bill Wendling
2020-02-26 20:12 ` [kvm-unit-tests PATCH v3 1/7] x86: emulator: use "SSE2" for the target Bill Wendling
2020-02-26 20:12 ` [kvm-unit-tests PATCH v3 2/7] pci: cast masks to uint32_t for unsigned long values Bill Wendling
2020-02-26 20:12 ` [kvm-unit-tests PATCH v3 3/7] x86: realmode: syscall: add explicit size suffix to ambiguous instructions Bill Wendling
2020-02-26 20:12 ` [kvm-unit-tests PATCH v3 4/7] svm: change operand to output-only for matching constraint Bill Wendling
2020-02-26 20:12 ` [kvm-unit-tests PATCH v3 5/7] svm: convert neg shift to unsigned shift Bill Wendling
2020-02-26 20:12 ` [kvm-unit-tests PATCH v3 6/7] x86: VMX: use inline asm to get stack pointer Bill Wendling
2020-02-26 20:12 ` [kvm-unit-tests PATCH v3 7/7] x86: VMX: the "noclone" attribute is gcc-specific Bill Wendling
2020-02-27 2:05 ` Oliver Upton
2020-02-28 11:19 ` [kvm-unit-tests PATCH v2 0/7] Fixes for clang builds Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226074427.169684-3-morbo@google.com \
--to=morbo@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).