From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBB1FC3F2D1 for ; Tue, 3 Mar 2020 15:54:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C72E520CC7 for ; Tue, 3 Mar 2020 15:54:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730088AbgCCPyd (ORCPT ); Tue, 3 Mar 2020 10:54:33 -0500 Received: from mga05.intel.com ([192.55.52.43]:45594 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729638AbgCCPyc (ORCPT ); Tue, 3 Mar 2020 10:54:32 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Mar 2020 07:54:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,511,1574150400"; d="scan'208";a="351862250" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.202]) by fmsmga001.fm.intel.com with ESMTP; 03 Mar 2020 07:54:26 -0800 Date: Tue, 3 Mar 2020 07:54:25 -0800 From: Sean Christopherson To: Paolo Bonzini Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Xiaoyao Li Subject: Re: [PATCH v2 36/66] KVM: x86: Handle GBPAGE CPUID adjustment for EPT in VMX code Message-ID: <20200303155425.GG1439@linux.intel.com> References: <20200302235709.27467-1-sean.j.christopherson@intel.com> <20200302235709.27467-37-sean.j.christopherson@intel.com> <90df7276-e586-9082-3d80-6b45e0fb4670@redhat.com> <20200303153550.GC1439@linux.intel.com> <20200303154453.GF1439@linux.intel.com> <21298366-2604-186d-1385-c2a04c74bad7@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21298366-2604-186d-1385-c2a04c74bad7@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Mar 03, 2020 at 04:47:46PM +0100, Paolo Bonzini wrote: > On 03/03/20 16:44, Sean Christopherson wrote: > >>> Oof, that took me a long time to process. You're saying that KVM can > >>> allow the guest to use GBPAGES when shadow paging is enabled because KVM > >>> can effectively emulate GBPAGES. And IIUC, you're also saying that > >>> cpuid.GBPAGES should never be influenced by EPT restrictions. > >>> > >>> That all makes sense. > >> Yes, exactly. > > I'll tack that on to the front of the series. Should it be tagged Fixes? > > Feels like a fix, but is also more than a bit scary. > > If you don't mind, I prefer to do the changes myself and also fix the > conflicts, in order to get my feet wet in the new cpu_caps world. I'll > push it to a temporary branch for you to take a look, possibly tomorrow. That would be wonderful, thanks!