From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Joao Martins <joao.m.martins@oracle.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH] cpuidle-haltpoll: allow force loading on hosts without the REALTIME hint
Date: Tue, 10 Mar 2020 10:50:06 -0300 [thread overview]
Message-ID: <20200310135006.GA6397@fuller.cnet> (raw)
In-Reply-To: <2118832.28snYOIflM@kreacher>
On Wed, Mar 04, 2020 at 11:31:31AM +0100, Rafael J. Wysocki wrote:
> On Friday, February 28, 2020 6:10:18 PM CET Maciej S. Szmigiero wrote:
> > A friendly ping here.
> >
> > Maciej
> >
> > On 21.02.2020 18:43, Maciej S. Szmigiero wrote:
> > > From: "Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>
> > >
> > > Before commit 1328edca4a14 ("cpuidle-haltpoll: Enable kvm guest polling
> > > when dedicated physical CPUs are available") the cpuidle-haltpoll driver
> > > could also be used in scenarios when the host does not advertise the
> > > KVM_HINTS_REALTIME hint.
> > >
> > > While the behavior introduced by the aforementioned commit makes sense as
> > > the default there are cases where the old behavior is desired, for example,
> > > when other kernel changes triggered by presence by this hint are unwanted,
> > > for some workloads where the latency benefit from polling overweights the
> > > loss from idle CPU capacity that otherwise would be available, or just when
> > > running under older Qemu versions that lack this hint.
> > >
> > > Let's provide a typical "force" module parameter that allows restoring the
> > > old behavior.
> > >
> > > Signed-off-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
> > > ---
> > > drivers/cpuidle/cpuidle-haltpoll.c | 12 +++++++++++-
> > > 1 file changed, 11 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/cpuidle/cpuidle-haltpoll.c b/drivers/cpuidle/cpuidle-haltpoll.c
> > > index b0ce9bc78113..07e5b36076bb 100644
> > > --- a/drivers/cpuidle/cpuidle-haltpoll.c
> > > +++ b/drivers/cpuidle/cpuidle-haltpoll.c
> > > @@ -18,6 +18,11 @@
> > > #include <linux/kvm_para.h>
> > > #include <linux/cpuidle_haltpoll.h>
> > >
> > > +static bool force __read_mostly;
> > > +module_param(force, bool, 0444);
> > > +MODULE_PARM_DESC(force,
> > > + "Load even if the host does not provide the REALTIME hint");
>
> Why not to say "Load unconditionally" here?
Makes sense to me.
> As is, one needs to know what "the REALTIME hint" is to understand it.
>
> > > +
> > > static struct cpuidle_device __percpu *haltpoll_cpuidle_devices;
> > > static enum cpuhp_state haltpoll_hp_state;
> > >
> > > @@ -90,6 +95,11 @@ static void haltpoll_uninit(void)
> > > haltpoll_cpuidle_devices = NULL;
> > > }
> > >
> > > +static bool haltpool_want(void)
> > > +{
> > > + return kvm_para_has_hint(KVM_HINTS_REALTIME) || force;
> > > +}
> > > +
> > > static int __init haltpoll_init(void)
> > > {
> > > int ret;
> > > @@ -102,7 +112,7 @@ static int __init haltpoll_init(void)
> > > cpuidle_poll_state_init(drv);
> > >
> > > if (!kvm_para_available() ||
> > > - !kvm_para_has_hint(KVM_HINTS_REALTIME))
> > > + !haltpool_want())
>
> And you don't need to break this line.
>
> > > return -ENODEV;
> > >
> > > ret = cpuidle_register_driver(drv);
> > >
> >
> >
>
> Thanks!
>
>
next prev parent reply other threads:[~2020-03-10 17:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200221174331.1480468-1-mail@maciej.szmigiero.name>
2020-02-24 20:10 ` [PATCH] cpuidle-haltpoll: allow force loading on hosts without the REALTIME hint Maciej S. Szmigiero
2020-03-06 9:56 ` Marcelo Tosatti
2020-03-06 20:11 ` Maciej S. Szmigiero
2020-02-28 17:10 ` Maciej S. Szmigiero
2020-03-04 10:31 ` Rafael J. Wysocki
2020-03-10 13:50 ` Marcelo Tosatti [this message]
2020-03-11 21:30 ` Maciej S. Szmigiero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310135006.GA6397@fuller.cnet \
--to=mtosatti@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=daniel.lezcano@linaro.org \
--cc=joao.m.martins@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).