kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Joao Martins <joao.m.martins@oracle.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	kvm@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] cpuidle-haltpoll: allow force loading on hosts without the REALTIME hint
Date: Thu, 12 Mar 2020 13:17:51 -0300	[thread overview]
Message-ID: <20200312161751.GA5245@fuller.cnet> (raw)
In-Reply-To: <20200304113248.1143057-1-mail@maciej.szmigiero.name>

On Wed, Mar 04, 2020 at 12:32:48PM +0100, Maciej S. Szmigiero wrote:
> From: "Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>
> 
> Before commit 1328edca4a14 ("cpuidle-haltpoll: Enable kvm guest polling
> when dedicated physical CPUs are available") the cpuidle-haltpoll driver
> could also be used in scenarios when the host does not advertise the
> KVM_HINTS_REALTIME hint.
> 
> While the behavior introduced by the aforementioned commit makes sense as
> the default there are cases where the old behavior is desired, for example,
> when other kernel changes triggered by presence by this hint are unwanted,
> for some workloads where the latency benefit from polling overweights the
> loss from idle CPU capacity that otherwise would be available, or just when
> running under older Qemu versions that lack this hint.
> 
> Let's provide a typical "force" module parameter that allows restoring the
> old behavior.
> 
> Signed-off-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
> ---
>  drivers/cpuidle/cpuidle-haltpoll.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> Changes from v1:
> Make the module parameter description more general, don't unnecessarily
> break a line in haltpoll_init().
> 
> diff --git a/drivers/cpuidle/cpuidle-haltpoll.c b/drivers/cpuidle/cpuidle-haltpoll.c
> index b0ce9bc78113..db124bc1ca2c 100644
> --- a/drivers/cpuidle/cpuidle-haltpoll.c
> +++ b/drivers/cpuidle/cpuidle-haltpoll.c
> @@ -18,6 +18,10 @@
>  #include <linux/kvm_para.h>
>  #include <linux/cpuidle_haltpoll.h>
>  
> +static bool force __read_mostly;
> +module_param(force, bool, 0444);
> +MODULE_PARM_DESC(force, "Load unconditionally");
> +
>  static struct cpuidle_device __percpu *haltpoll_cpuidle_devices;
>  static enum cpuhp_state haltpoll_hp_state;
>  
> @@ -90,6 +94,11 @@ static void haltpoll_uninit(void)
>  	haltpoll_cpuidle_devices = NULL;
>  }
>  
> +static bool haltpool_want(void)
> +{
> +	return kvm_para_has_hint(KVM_HINTS_REALTIME) || force;
> +}
> +
>  static int __init haltpoll_init(void)
>  {
>  	int ret;
> @@ -101,8 +110,7 @@ static int __init haltpoll_init(void)
>  
>  	cpuidle_poll_state_init(drv);
>  
> -	if (!kvm_para_available() ||
> -		!kvm_para_has_hint(KVM_HINTS_REALTIME))
> +	if (!kvm_para_available() || !haltpool_want())
>  		return -ENODEV;
>  
>  	ret = cpuidle_register_driver(drv);

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>


  reply	other threads:[~2020-03-12 16:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04 11:32 Maciej S. Szmigiero
2020-03-12 16:17 ` Marcelo Tosatti [this message]
2020-03-13 17:49   ` Rafael J. Wysocki
2020-03-14 10:40     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200312161751.GA5245@fuller.cnet \
    --to=mtosatti@redhat.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=joao.m.martins@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mail@maciej.szmigiero.name \
    --cc=rjw@rjwysocki.net \
    --subject='Re: [PATCH v2] cpuidle-haltpoll: allow force loading on hosts without the REALTIME hint' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).