From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEE2FC43331 for ; Thu, 26 Mar 2020 09:33:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9AAC62073E for ; Thu, 26 Mar 2020 09:33:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="F6JlYzTi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727750AbgCZJdm (ORCPT ); Thu, 26 Mar 2020 05:33:42 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:40094 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727699AbgCZJdm (ORCPT ); Thu, 26 Mar 2020 05:33:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=D7iUfyyuqm+dw4598KbpWIu+GERU4Vqzux8/iRw3Pco=; b=F6JlYzTiE+9B++gXkAJKN3WCxV xWwamyGhjsFIpTTEiZN042yCZfOx7/WEBR+9I4WHpGyGUs0oazlAvy9UJ4SmSW35mN3rfl2IA3lfR Niw5LZyeb2oojAHa0fYTjZEAWUqqOayoJPg8jTMXN3Px173WZEwiNsjQdhyl6CRIWTw/NoSVBLv84 DHTNLHasfYNNfophQ+se8/udStYa7K/hpOWKIBIA7h8D6BgoUVWf79Pft/YBAUMBtE89HdJBXH2N/ ajqcfx5Gc0BmlcoU2M4eD0w2EXPaBKcA3kGZuqwb8iZCnK4sZZqDIho14z/yBpzbzcBpx94aF0xpy iyedccrA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jHOsw-0003Fy-SL; Thu, 26 Mar 2020 09:33:10 +0000 Date: Thu, 26 Mar 2020 02:33:10 -0700 From: Christoph Hellwig To: Kirti Wankhede Cc: alex.williamson@redhat.com, cjia@nvidia.com, kevin.tian@intel.com, ziye.yang@intel.com, changpeng.liu@intel.com, yi.l.liu@intel.com, mlevitsk@redhat.com, eskultet@redhat.com, cohuck@redhat.com, dgilbert@redhat.com, jonathan.davies@nutanix.com, eauger@redhat.com, aik@ozlabs.ru, pasic@linux.ibm.com, felipe@nutanix.com, Zhengxiao.zx@alibaba-inc.com, shuangtai.tst@alibaba-inc.com, Ken.Xue@amd.com, zhi.a.wang@intel.com, yan.y.zhao@intel.com, qemu-devel@nongnu.org, kvm@vger.kernel.org Subject: Re: [PATCH v15 Kernel 1/7] vfio: KABI for migration interface for device state Message-ID: <20200326093310.GA12078@infradead.org> References: <1584649004-8285-1-git-send-email-kwankhede@nvidia.com> <1584649004-8285-2-git-send-email-kwankhede@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1584649004-8285-2-git-send-email-kwankhede@nvidia.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org s/KABI/UAPI/ in the subject and anywhere else in the series. Please avoid __packed__ structures and just properly pad them, they have a major performance impact on some platforms and will cause compiler warnings when taking addresses of members.