KVM Archive on lore.kernel.org
 help / color / Atom feed
* [kvm:queue 276/278] arch/x86/kvm/svm/nested.c:88:49: error: invalid type argument of '->' (have 'struct kvm_x86_ops')
@ 2020-03-27  0:29 kbuild test robot
  2020-03-27  1:40 ` Sean Christopherson
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2020-03-27  0:29 UTC (permalink / raw)
  To: Joerg Roedel
  Cc: kbuild-all, kvm, Robert Hu, Farrah Chen, Danmei Wei, Paolo Bonzini


[-- Attachment #1: Type: text/plain, Size: 1699 bytes --]

tree:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue
head:   a7740c8860d7b1e47fa34fdc66e6d35ceb5e04ea
commit: 6ddc990b96df159a95b1f6c50f207c20b409f818 [276/278] KVM: SVM: Move Nested SVM Implementation to nested.c
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-5) 7.5.0
reproduce:
        git checkout 6ddc990b96df159a95b1f6c50f207c20b409f818
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   arch/x86/kvm/svm/nested.c: In function 'nested_svm_init_mmu_context':
>> arch/x86/kvm/svm/nested.c:88:49: error: invalid type argument of '->' (have 'struct kvm_x86_ops')
     vcpu->arch.mmu->shadow_root_level = kvm_x86_ops->get_tdp_level(vcpu);
                                                    ^~

vim +88 arch/x86/kvm/svm/nested.c

    78	
    79	static void nested_svm_init_mmu_context(struct kvm_vcpu *vcpu)
    80	{
    81		WARN_ON(mmu_is_nested(vcpu));
    82	
    83		vcpu->arch.mmu = &vcpu->arch.guest_mmu;
    84		kvm_init_shadow_mmu(vcpu);
    85		vcpu->arch.mmu->get_guest_pgd     = nested_svm_get_tdp_cr3;
    86		vcpu->arch.mmu->get_pdptr         = nested_svm_get_tdp_pdptr;
    87		vcpu->arch.mmu->inject_page_fault = nested_svm_inject_npf_exit;
  > 88		vcpu->arch.mmu->shadow_root_level = kvm_x86_ops->get_tdp_level(vcpu);
    89		reset_shadow_zero_bits_mask(vcpu, vcpu->arch.mmu);
    90		vcpu->arch.walk_mmu              = &vcpu->arch.nested_mmu;
    91	}
    92	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 71473 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [kvm:queue 276/278] arch/x86/kvm/svm/nested.c:88:49: error: invalid type argument of '->' (have 'struct kvm_x86_ops')
  2020-03-27  0:29 [kvm:queue 276/278] arch/x86/kvm/svm/nested.c:88:49: error: invalid type argument of '->' (have 'struct kvm_x86_ops') kbuild test robot
@ 2020-03-27  1:40 ` Sean Christopherson
  2020-03-27  8:42   ` Paolo Bonzini
  0 siblings, 1 reply; 3+ messages in thread
From: Sean Christopherson @ 2020-03-27  1:40 UTC (permalink / raw)
  To: kbuild test robot
  Cc: Joerg Roedel, kbuild-all, kvm, Robert Hu, Farrah Chen,
	Danmei Wei, Paolo Bonzini

On Fri, Mar 27, 2020 at 08:29:47AM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue
>    arch/x86/kvm/svm/nested.c: In function 'nested_svm_init_mmu_context':
> >> arch/x86/kvm/svm/nested.c:88:49: error: invalid type argument of '->' (have 'struct kvm_x86_ops')
>      vcpu->arch.mmu->shadow_root_level = kvm_x86_ops->get_tdp_level(vcpu);
>                                                     ^~
> 
> vim +88 arch/x86/kvm/svm/nested.c
> 
>     78	
>     79	static void nested_svm_init_mmu_context(struct kvm_vcpu *vcpu)
>     80	{
>     81		WARN_ON(mmu_is_nested(vcpu));
>     82	
>     83		vcpu->arch.mmu = &vcpu->arch.guest_mmu;
>     84		kvm_init_shadow_mmu(vcpu);
>     85		vcpu->arch.mmu->get_guest_pgd     = nested_svm_get_tdp_cr3;
>     86		vcpu->arch.mmu->get_pdptr         = nested_svm_get_tdp_pdptr;
>     87		vcpu->arch.mmu->inject_page_fault = nested_svm_inject_npf_exit;
>   > 88		vcpu->arch.mmu->shadow_root_level = kvm_x86_ops->get_tdp_level(vcpu);

Tip of the iceberg.  kvm.git/queue is totally busted, the last two commits
remove code from svm.c but don't create the new files.

  $ git-tree kvm/queue
  arch/x86/kvm/Makefile
  arch/x86/kvm/svm/svm.c
  arch/x86/kvm/svm/svm.h

  $ gwo kvm/queue
  a7740c8860d7 ("KVM: SVM: Move SEV code to separate file")

>     89		reset_shadow_zero_bits_mask(vcpu, vcpu->arch.mmu);
>     90		vcpu->arch.walk_mmu              = &vcpu->arch.nested_mmu;
>     91	}
>     92	
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [kvm:queue 276/278] arch/x86/kvm/svm/nested.c:88:49: error: invalid type argument of '->' (have 'struct kvm_x86_ops')
  2020-03-27  1:40 ` Sean Christopherson
@ 2020-03-27  8:42   ` Paolo Bonzini
  0 siblings, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2020-03-27  8:42 UTC (permalink / raw)
  To: Sean Christopherson, kbuild test robot
  Cc: Joerg Roedel, kbuild-all, kvm, Robert Hu, Farrah Chen, Danmei Wei

On 27/03/20 02:40, Sean Christopherson wrote:
> On Fri, Mar 27, 2020 at 08:29:47AM +0800, kbuild test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue
>>    arch/x86/kvm/svm/nested.c: In function 'nested_svm_init_mmu_context':
>>>> arch/x86/kvm/svm/nested.c:88:49: error: invalid type argument of '->' (have 'struct kvm_x86_ops')
>>      vcpu->arch.mmu->shadow_root_level = kvm_x86_ops->get_tdp_level(vcpu);
>>                                                     ^~
>>
>> vim +88 arch/x86/kvm/svm/nested.c
>>
>>     78	
>>     79	static void nested_svm_init_mmu_context(struct kvm_vcpu *vcpu)
>>     80	{
>>     81		WARN_ON(mmu_is_nested(vcpu));
>>     82	
>>     83		vcpu->arch.mmu = &vcpu->arch.guest_mmu;
>>     84		kvm_init_shadow_mmu(vcpu);
>>     85		vcpu->arch.mmu->get_guest_pgd     = nested_svm_get_tdp_cr3;
>>     86		vcpu->arch.mmu->get_pdptr         = nested_svm_get_tdp_pdptr;
>>     87		vcpu->arch.mmu->inject_page_fault = nested_svm_inject_npf_exit;
>>   > 88		vcpu->arch.mmu->shadow_root_level = kvm_x86_ops->get_tdp_level(vcpu);
> 
> Tip of the iceberg.  kvm.git/queue is totally busted, the last two commits
> remove code from svm.c but don't create the new files.

Yes, totally.  I wanted to push before the split and messed up.

Paolo


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-27  0:29 [kvm:queue 276/278] arch/x86/kvm/svm/nested.c:88:49: error: invalid type argument of '->' (have 'struct kvm_x86_ops') kbuild test robot
2020-03-27  1:40 ` Sean Christopherson
2020-03-27  8:42   ` Paolo Bonzini

KVM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/kvm/0 kvm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kvm kvm/ https://lore.kernel.org/kvm \
		kvm@vger.kernel.org
	public-inbox-index kvm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.kvm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git