From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E65CDC352BE for ; Thu, 16 Apr 2020 13:31:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8F2520767 for ; Thu, 16 Apr 2020 13:31:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2896337AbgDPNa5 (ORCPT ); Thu, 16 Apr 2020 09:30:57 -0400 Received: from 8bytes.org ([81.169.241.247]:36022 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2896315AbgDPNax (ORCPT ); Thu, 16 Apr 2020 09:30:53 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id E492DED; Thu, 16 Apr 2020 15:30:46 +0200 (CEST) Date: Thu, 16 Apr 2020 15:30:45 +0200 From: Joerg Roedel To: Arvind Sankar Cc: x86@kernel.org, hpa@zytor.com, Andy Lutomirski , Dave Hansen , Peter Zijlstra , Thomas Hellstrom , Jiri Slaby , Dan Williams , Tom Lendacky , Juergen Gross , Kees Cook , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, Joerg Roedel Subject: Re: [PATCH 12/70] x86/boot/compressed/64: Add IDT Infrastructure Message-ID: <20200416133045.GA4290@8bytes.org> References: <20200319091407.1481-1-joro@8bytes.org> <20200319091407.1481-13-joro@8bytes.org> <20200407022127.GA1048595@rani.riverdale.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200407022127.GA1048595@rani.riverdale.lan> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Arvind, On Mon, Apr 06, 2020 at 10:21:27PM -0400, Arvind Sankar wrote: > On Thu, Mar 19, 2020 at 10:13:09AM +0100, Joerg Roedel wrote: > > From: Joerg Roedel > > +/* > > + * Reload GDT after relocation - The GDT at the non-relocated position > > + * might be overwritten soon by the in-place decompression, so reload > > + * GDT at the relocated address. The GDT is referenced by exception > > + * handling and needs to be set up correctly. > > + */ > > + leaq gdt(%rip), %rax > > + movq %rax, gdt64+2(%rip) > > + lgdt gdt64(%rip) > > + > > /* > > * Clear BSS (stack is currently empty) > > */ > > Note that this is now done in mainline as of commit c98a76eabbb6e, just > prior to jumping to .Lrelocated, so this can be dropped on the next > rebase. Thanks for the heads-up, I removed this hunk. Regards, Joerg