From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C19C5C47254 for ; Tue, 5 May 2020 15:45:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A19AF206B9 for ; Tue, 5 May 2020 15:45:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LTzqHOoA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730498AbgEEPpH (ORCPT ); Tue, 5 May 2020 11:45:07 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:51018 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729612AbgEEPpF (ORCPT ); Tue, 5 May 2020 11:45:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588693504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ATymMeG6RiOGBAAfWdg7fwilnSvvAev3slucMk0tl5E=; b=LTzqHOoAHMTaoulqQm2U/zYIOcQsmrQp8lCqK+I5WFP8DipQD9Z+9oNOZFfUt+Y84CFWS9 FoZrIJWdJy7UDAsFrMEMXPiIFLcedLgk/siqb491Lyx5BkkoNqpMPzTgVVEEIQU23ITWUN WQ99yDrt6j7pqZAn1Qv6fAZmYfBn9SU= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-81-1t9Gm0lUOlC70bbsTuI5dQ-1; Tue, 05 May 2020 11:44:53 -0400 X-MC-Unique: 1t9Gm0lUOlC70bbsTuI5dQ-1 Received: by mail-wm1-f70.google.com with SMTP id f81so1060009wmf.2 for ; Tue, 05 May 2020 08:44:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ATymMeG6RiOGBAAfWdg7fwilnSvvAev3slucMk0tl5E=; b=KchTkmM6Gm4QMOlvEh9J82MWjlN3w6fB16tG06c5jpLqyRBEjIIwGZv1wuH1mgzrxC aW33sEnw6vcpNPuQflMN1fcJ99VU92cRTk5Y61hjIuISRR7fz7DS7J6ZxVkjQjgyfrDZ mDYIQssXzgQuCkyWbgVu+sAzyRGXecPAzU4jLVULFfSEs02nHbx3rH4NrOq7s/cp3TvN G0K3nZhuKFy15CyeIJGFN+vWZdcFzJYSGf5EdgTmj3cozwkQMP8j8fw4M8zKUNkzVQoR LQcx84jEHXdL5ff5N6KrCIR55KgeQcthnUAOBQqWM0W+T1w5TsAzPKjoFC8z6hkDOpYS MkPg== X-Gm-Message-State: AGi0PuaNiz8tdVxcdYMfeUAy9JKKbJPOVsCNVpB7BTuVXzCReRbYvv+o FOIsvZzcIabay8pLhZCwW95ldP89IDKTKZcoJvR081RDMT3I4NDqiwX5gdiGui7QupQkPap5uzG CusufH/Bv0iQC X-Received: by 2002:a1c:7416:: with SMTP id p22mr4193890wmc.80.1588693492674; Tue, 05 May 2020 08:44:52 -0700 (PDT) X-Google-Smtp-Source: APiQypLAtAtR29+1Xpb9v/bXxgErbXkwmiM0ZkUgsrIiaMjwwteCzask/x8xdzj9MT0cC1whI9Hdyw== X-Received: by 2002:a05:600c:220c:: with SMTP id z12mr3889139wml.84.1588693492106; Tue, 05 May 2020 08:44:52 -0700 (PDT) Received: from redhat.com (bzq-109-66-7-121.red.bezeqint.net. [109.66.7.121]) by smtp.gmail.com with ESMTPSA id x13sm4635004wmc.5.2020.05.05.08.44.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2020 08:44:51 -0700 (PDT) Date: Tue, 5 May 2020 11:44:48 -0400 From: "Michael S. Tsirkin" To: David Hildenbrand Cc: kbuild test robot , kbuild-all@lists.01.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, Pankaj Gupta Subject: Re: [vhost:vhost 8/22] drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? Message-ID: <20200505114433-mutt-send-email-mst@kernel.org> References: <202005052221.83QerHmG%lkp@intel.com> <7dea2810-85cf-0892-20a8-bba3e3a2c133@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7dea2810-85cf-0892-20a8-bba3e3a2c133@redhat.com> Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, May 05, 2020 at 04:50:13PM +0200, David Hildenbrand wrote: > On 05.05.20 16:15, kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost > > head: da1742791d8c0c0a8e5471f181549c4726a5c5f9 > > commit: 7527631e900d464ed2d533f799cb0da2b29cc6f0 [8/22] virtio-mem: Paravirtualized memory hotplug > > config: x86_64-randconfig-b002-20200505 (attached as .config) > > compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 > > reproduce: > > git checkout 7527631e900d464ed2d533f799cb0da2b29cc6f0 > > # save the attached .config to linux build tree > > make ARCH=x86_64 > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kbuild test robot > > > > All error/warnings (new ones prefixed by >>): > > > > drivers/virtio/virtio_mem.c: In function 'virtio_mem_probe': > >>> drivers/virtio/virtio_mem.c:1375:20: error: implicit declaration of function 'kzalloc'; did you mean 'vzalloc'? [-Werror=implicit-function-declaration] > > vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL); > > ^~~~~~~ > > vzalloc > >>> drivers/virtio/virtio_mem.c:1375:18: warning: assignment makes pointer from integer without a cast [-Wint-conversion] > > vdev->priv = vm = kzalloc(sizeof(*vm), GFP_KERNEL); > > ^ > >>> drivers/virtio/virtio_mem.c:1419:2: error: implicit declaration of function 'kfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration] > > kfree(vm); > > ^~~~~ > > vfree > > cc1: some warnings being treated as errors > > > > vim +1375 drivers/virtio/virtio_mem.c > > Guess we simply need > > #include > > to make it work for that config. OK I added that in the 1st commit that introduced virtio-mem. > -- > Thanks, > > David / dhildenb