From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8C97C28CBC for ; Wed, 6 May 2020 13:53:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E3DD20752 for ; Wed, 6 May 2020 13:53:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gnWe6HhA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728667AbgEFNxH (ORCPT ); Wed, 6 May 2020 09:53:07 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:34720 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725966AbgEFNxH (ORCPT ); Wed, 6 May 2020 09:53:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588773186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jch60/8K2tSA67AtwLBrzD6Tb8I7e5RgTzc+4TjfepU=; b=gnWe6HhAJAAZDlN2eKFMV7GVFR1+xQpMGmWeUmqGBPz/CtIhgZ93bMXGUdIs0PZnQ0dBTj Y0r6vSd18ChuEcHF4Xudu3qnchupN6zM9b2MduqbtPvk7Cw6UIwOJtA8rSRPpH9iJ217jK SDa/1HxL2mKnU6ioDImucsE3N2bs8+A= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-176-QqblW9vcP16c8c1L94vUeA-1; Wed, 06 May 2020 09:53:04 -0400 X-MC-Unique: QqblW9vcP16c8c1L94vUeA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 46DAE18FE863; Wed, 6 May 2020 13:53:03 +0000 (UTC) Received: from gondolin (ovpn-112-211.ams2.redhat.com [10.36.112.211]) by smtp.corp.redhat.com (Postfix) with ESMTP id DB73010013D9; Wed, 6 May 2020 13:53:01 +0000 (UTC) Date: Wed, 6 May 2020 15:52:59 +0200 From: Cornelia Huck To: Eric Farman Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org, Halil Pasic , Jason Herne , Jared Rossi Subject: Re: [PATCH v4 7/8] vfio-ccw: Wire up the CRW irq and CRW region Message-ID: <20200506155259.4ec538e2.cohuck@redhat.com> In-Reply-To: <20200505122745.53208-8-farman@linux.ibm.com> References: <20200505122745.53208-1-farman@linux.ibm.com> <20200505122745.53208-8-farman@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, 5 May 2020 14:27:44 +0200 Eric Farman wrote: > From: Farhan Ali > > Use the IRQ to notify userspace that there is a CRW > pending in the region, related to path-availability > changes on the passthrough subchannel. > > Signed-off-by: Farhan Ali > Signed-off-by: Eric Farman > --- > > Notes: > v3->v4: > - s/vfio_ccw_alloc_crw()/vfio_ccw_queue_crw()/ [CH] > - Remove cssid from crw that is built [CH] > > v2->v3: > - Refactor vfio_ccw_alloc_crw() to accept rsc, erc, and rsid fields > of a CRW as input [CH] > - Copy the right amount of CRWs to the crw_region [EF] > - Use sizeof(target) for the memcpy, rather than sizeof(source) [EF] > - Ensure the CRW region is empty if no CRW is present [EF/CH] > - Refactor how data goes from private-to-region-to-user [CH] > - Reduce the number of CRWs from two to one [CH] > - s/vc_crw/crw/ [EF] > > v1->v2: > - Remove extraneous 0x0 in crw.rsid assignment [CH] > - Refactor the building/queueing of a crw into its own routine [EF] > > v0->v1: [EF] > - Place the non-refactoring changes from the previous patch here > - Clean up checkpatch (whitespace) errors > - s/chp_crw/crw/ > - Move acquire/release of io_mutex in vfio_ccw_crw_region_read() > into patch that introduces that region > - Remove duplicate include from vfio_ccw_drv.c > - Reorder include in vfio_ccw_private.h > > drivers/s390/cio/vfio_ccw_chp.c | 17 ++++++++++ > drivers/s390/cio/vfio_ccw_drv.c | 49 +++++++++++++++++++++++++++++ > drivers/s390/cio/vfio_ccw_private.h | 8 +++++ > 3 files changed, 74 insertions(+) Reviewed-by: Cornelia Huck