From: Vivek Goyal <vgoyal@redhat.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: kvm@vger.kernel.org, x86@kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
Wanpeng Li <wanpengli@tencent.com>,
Sean Christopherson <sean.j.christopherson@intel.com>,
Jim Mattson <jmattson@google.com>, Gavin Shan <gshan@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/8] KVM: x86: Interrupt-based mechanism for async_pf 'page present' notifications
Date: Tue, 12 May 2020 11:32:09 -0400 [thread overview]
Message-ID: <20200512153209.GC138129@redhat.com> (raw)
In-Reply-To: <20200511164752.2158645-1-vkuznets@redhat.com>
Hi Vitaly,
Are there any corresponding qemu patches as well to enable new
functionality. Wanted to test it.
Thanks
Vivek
On Mon, May 11, 2020 at 06:47:44PM +0200, Vitaly Kuznetsov wrote:
> Concerns were expressed around (ab)using #PF for KVM's async_pf mechanism,
> it seems that re-using #PF exception for a PV mechanism wasn't a great
> idea after all. The Grand Plan is to switch to using e.g. #VE for 'page
> not present' events and normal APIC interrupts for 'page ready' events.
> This series does the later.
>
> Changes since RFC:
> - Using #PF for 'page ready' is deprecated and removed [Paolo Bonzini]
> - 'reason' field in 'struct kvm_vcpu_pv_apf_data' is not used for 'page ready'
> notifications and 'pageready_token' is not used for 'page not present' events
> [Paolo Bonzini]
> - Renamed MSR_KVM_ASYNC_PF2 -> MSR_KVM_ASYNC_PF_INT [Peter Xu]
> - Drop 'enabled' field from MSR_KVM_ASYNC_PF_INT [Peter Xu]
> - Other minor changes supporting the above.
>
> Vitaly Kuznetsov (8):
> Revert "KVM: async_pf: Fix #DF due to inject "Page not Present" and
> "Page Ready" exceptions simultaneously"
> KVM: x86: extend struct kvm_vcpu_pv_apf_data with token info
> KVM: introduce kvm_read_guest_offset_cached()
> KVM: x86: interrupt based APF page-ready event delivery
> KVM: x86: acknowledgment mechanism for async pf page ready
> notifications
> KVM: x86: announce KVM_FEATURE_ASYNC_PF_INT
> KVM: x86: Switch KVM guest to using interrupts for page ready APF
> delivery
> KVM: x86: drop KVM_PV_REASON_PAGE_READY case from
> kvm_handle_page_fault()
>
> Documentation/virt/kvm/cpuid.rst | 6 ++
> Documentation/virt/kvm/msr.rst | 106 ++++++++++++++------
> arch/s390/include/asm/kvm_host.h | 2 +
> arch/x86/entry/entry_32.S | 5 +
> arch/x86/entry/entry_64.S | 5 +
> arch/x86/include/asm/hardirq.h | 3 +
> arch/x86/include/asm/irq_vectors.h | 6 +-
> arch/x86/include/asm/kvm_host.h | 7 +-
> arch/x86/include/asm/kvm_para.h | 6 ++
> arch/x86/include/uapi/asm/kvm_para.h | 11 ++-
> arch/x86/kernel/irq.c | 9 ++
> arch/x86/kernel/kvm.c | 42 ++++++--
> arch/x86/kvm/cpuid.c | 3 +-
> arch/x86/kvm/mmu/mmu.c | 10 +-
> arch/x86/kvm/x86.c | 142 ++++++++++++++++++---------
> include/linux/kvm_host.h | 3 +
> include/uapi/linux/kvm.h | 1 +
> virt/kvm/async_pf.c | 10 ++
> virt/kvm/kvm_main.c | 19 +++-
> 19 files changed, 295 insertions(+), 101 deletions(-)
>
> --
> 2.25.4
>
next prev parent reply other threads:[~2020-05-12 15:32 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 16:47 [PATCH 0/8] KVM: x86: Interrupt-based mechanism for async_pf 'page present' notifications Vitaly Kuznetsov
2020-05-11 16:47 ` [PATCH 1/8] Revert "KVM: async_pf: Fix #DF due to inject "Page not Present" and "Page Ready" exceptions simultaneously" Vitaly Kuznetsov
2020-05-11 16:47 ` [PATCH 2/8] KVM: x86: extend struct kvm_vcpu_pv_apf_data with token info Vitaly Kuznetsov
2020-05-12 15:27 ` Vivek Goyal
2020-05-12 15:40 ` Vitaly Kuznetsov
2020-05-12 15:53 ` Vivek Goyal
2020-05-12 17:50 ` Sean Christopherson
2020-05-13 9:09 ` Vitaly Kuznetsov
2020-05-13 12:52 ` Vivek Goyal
2020-05-15 15:59 ` Paolo Bonzini
2020-05-15 18:46 ` Sean Christopherson
2020-05-15 19:18 ` Paolo Bonzini
2020-05-15 20:33 ` Vivek Goyal
2020-05-15 20:53 ` Sean Christopherson
2020-05-15 20:43 ` Sean Christopherson
2020-05-15 22:23 ` Paolo Bonzini
2020-05-15 23:16 ` Sean Christopherson
2020-05-21 14:59 ` Vitaly Kuznetsov
2020-05-22 7:33 ` Paolo Bonzini
2020-05-12 21:15 ` Vivek Goyal
2020-05-21 18:38 ` Vivek Goyal
2020-05-23 16:34 ` Vitaly Kuznetsov
2020-05-26 12:50 ` Vivek Goyal
2020-05-11 16:47 ` [PATCH 3/8] KVM: introduce kvm_read_guest_offset_cached() Vitaly Kuznetsov
2020-05-11 16:47 ` [PATCH 4/8] KVM: x86: interrupt based APF page-ready event delivery Vitaly Kuznetsov
2020-05-12 14:24 ` Vivek Goyal
2020-05-12 15:50 ` Vitaly Kuznetsov
2020-05-12 18:07 ` Vivek Goyal
2020-05-13 9:03 ` Vitaly Kuznetsov
2020-05-13 13:53 ` Vivek Goyal
2020-05-13 14:03 ` Vivek Goyal
2020-05-13 14:23 ` Vitaly Kuznetsov
2020-05-13 18:46 ` Vivek Goyal
2020-05-14 8:08 ` Vitaly Kuznetsov
2020-05-14 13:31 ` Vivek Goyal
2020-05-11 16:47 ` [PATCH 5/8] KVM: x86: acknowledgment mechanism for async pf page ready notifications Vitaly Kuznetsov
2020-05-11 16:47 ` [PATCH 6/8] KVM: x86: announce KVM_FEATURE_ASYNC_PF_INT Vitaly Kuznetsov
2020-05-11 16:47 ` [PATCH 7/8] KVM: x86: Switch KVM guest to using interrupts for page ready APF delivery Vitaly Kuznetsov
2020-05-13 1:44 ` [kbuild-all] " kbuild test robot
2020-05-11 16:47 ` [PATCH 8/8] KVM: x86: drop KVM_PV_REASON_PAGE_READY case from kvm_handle_page_fault() Vitaly Kuznetsov
2020-05-12 15:32 ` Vivek Goyal [this message]
2020-05-12 16:12 ` [PATCH 0/8] KVM: x86: Interrupt-based mechanism for async_pf 'page present' notifications Vitaly Kuznetsov
2020-05-13 14:16 ` Vivek Goyal
2020-05-14 18:14 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512153209.GC138129@redhat.com \
--to=vgoyal@redhat.com \
--cc=bp@alien8.de \
--cc=gshan@redhat.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=sean.j.christopherson@intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).