From: Thomas Huth <thuth@redhat.com>
To: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
Drew Jones <drjones@redhat.com>, Bill Wendling <morbo@google.com>
Subject: [kvm-unit-tests PATCH 09/11] x86: use inline asm to retrieve stack pointer
Date: Thu, 14 May 2020 21:26:24 +0200 [thread overview]
Message-ID: <20200514192626.9950-10-thuth@redhat.com> (raw)
In-Reply-To: <20200514192626.9950-1-thuth@redhat.com>
From: Bill Wendling <morbo@google.com>
According to GCC's documentation, the only supported use for specifying
registers for local variables is "to specify registers for input and
output operands when calling Extended asm." Using it as a shortcut to
get the value in a register isn't guaranteed to work, and clang
complains that the variable is uninitialized.
Signed-off-by: Bill Wendling <morbo@google.com>
Message-Id: <20191030210419.213407-7-morbo@google.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
x86/vmx_tests.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/x86/vmx_tests.c b/x86/vmx_tests.c
index 0909adb..dbf5375 100644
--- a/x86/vmx_tests.c
+++ b/x86/vmx_tests.c
@@ -2135,7 +2135,9 @@ static void into_guest_main(void)
.offset = (uintptr_t)&&into,
.selector = KERNEL_CS32,
};
- register uintptr_t rsp asm("rsp");
+ uintptr_t rsp;
+
+ asm volatile ("mov %%rsp, %0" : "=r"(rsp));
if (fp.offset != (uintptr_t)&&into) {
printf("Code address too high.\n");
@@ -3231,7 +3233,9 @@ static void try_compat_invvpid(void *unused)
.offset = (uintptr_t)&&invvpid,
.selector = KERNEL_CS32,
};
- register uintptr_t rsp asm("rsp");
+ uintptr_t rsp;
+
+ asm volatile ("mov %%rsp, %0" : "=r"(rsp));
TEST_ASSERT_MSG(fp.offset == (uintptr_t)&&invvpid,
"Code address too high.");
--
2.18.1
next prev parent reply other threads:[~2020-05-14 19:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 19:26 [kvm-unit-tests PATCH 00/11] Misc fixes and CI improvements Thomas Huth
2020-05-14 19:26 ` [kvm-unit-tests PATCH 01/11] x86/access: Fix phys-bits parameter Thomas Huth
2020-05-14 19:26 ` [kvm-unit-tests PATCH 02/11] Fix out-of-tree builds Thomas Huth
2020-05-14 19:26 ` [kvm-unit-tests PATCH 03/11] x86: avoid multiply defined symbol Thomas Huth
2020-05-14 19:26 ` [kvm-unit-tests PATCH 04/11] Fixes for the umip test Thomas Huth
2020-05-14 19:26 ` [kvm-unit-tests PATCH 05/11] Always compile the kvm-unit-tests with -fno-common Thomas Huth
2020-05-14 19:26 ` [kvm-unit-tests PATCH 06/11] Fix powerpc issue with the linker from Fedora 32 Thomas Huth
2020-05-14 19:26 ` [kvm-unit-tests PATCH 07/11] Update the gitlab-ci to " Thomas Huth
2020-05-14 19:26 ` [kvm-unit-tests PATCH 08/11] x86: use a non-negative number in shift Thomas Huth
2020-05-14 19:26 ` Thomas Huth [this message]
2020-05-14 19:26 ` [kvm-unit-tests PATCH 10/11] vmx_tests: Silence warning from Clang Thomas Huth
2020-05-14 19:26 ` [kvm-unit-tests PATCH 11/11] Compile the kvm-unit-tests also with Clang Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514192626.9950-10-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=morbo@google.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).