* [PATCH] vhost: missing __user tags
@ 2020-05-15 15:33 Michael S. Tsirkin
2020-05-18 3:27 ` Jason Wang
0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2020-05-15 15:33 UTC (permalink / raw)
To: linux-kernel; +Cc: kbuild test robot, Jason Wang, kvm, virtualization, netdev
sparse warns about converting void * to void __user *. This is not new
but only got noticed now that vhost is built on more systems.
This is just a question of __user tags missing in a couple of places,
so fix it up.
Fixes: f88949138058 ("vhost: introduce O(1) vq metadata cache")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
drivers/vhost/vhost.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index d450e16c5c25..21a59b598ed8 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -730,7 +730,7 @@ static inline void __user *vhost_vq_meta_fetch(struct vhost_virtqueue *vq,
if (!map)
return NULL;
- return (void *)(uintptr_t)(map->addr + addr - map->start);
+ return (void __user *)(uintptr_t)(map->addr + addr - map->start);
}
/* Can we switch to this memory table? */
@@ -869,7 +869,7 @@ static void __user *__vhost_get_user_slow(struct vhost_virtqueue *vq,
* not happen in this case.
*/
static inline void __user *__vhost_get_user(struct vhost_virtqueue *vq,
- void *addr, unsigned int size,
+ void __user *addr, unsigned int size,
int type)
{
void __user *uaddr = vhost_vq_meta_fetch(vq,
--
MST
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] vhost: missing __user tags
2020-05-15 15:33 [PATCH] vhost: missing __user tags Michael S. Tsirkin
@ 2020-05-18 3:27 ` Jason Wang
0 siblings, 0 replies; 2+ messages in thread
From: Jason Wang @ 2020-05-18 3:27 UTC (permalink / raw)
To: Michael S. Tsirkin, linux-kernel
Cc: kbuild test robot, kvm, virtualization, netdev
On 2020/5/15 下午11:33, Michael S. Tsirkin wrote:
> sparse warns about converting void * to void __user *. This is not new
> but only got noticed now that vhost is built on more systems.
> This is just a question of __user tags missing in a couple of places,
> so fix it up.
>
> Fixes: f88949138058 ("vhost: introduce O(1) vq metadata cache")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/vhost/vhost.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
> index d450e16c5c25..21a59b598ed8 100644
> --- a/drivers/vhost/vhost.c
> +++ b/drivers/vhost/vhost.c
> @@ -730,7 +730,7 @@ static inline void __user *vhost_vq_meta_fetch(struct vhost_virtqueue *vq,
> if (!map)
> return NULL;
>
> - return (void *)(uintptr_t)(map->addr + addr - map->start);
> + return (void __user *)(uintptr_t)(map->addr + addr - map->start);
> }
>
> /* Can we switch to this memory table? */
> @@ -869,7 +869,7 @@ static void __user *__vhost_get_user_slow(struct vhost_virtqueue *vq,
> * not happen in this case.
> */
> static inline void __user *__vhost_get_user(struct vhost_virtqueue *vq,
> - void *addr, unsigned int size,
> + void __user *addr, unsigned int size,
> int type)
> {
> void __user *uaddr = vhost_vq_meta_fetch(vq,
Acked-by: Jason Wang <jasowang@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-18 3:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-15 15:33 [PATCH] vhost: missing __user tags Michael S. Tsirkin
2020-05-18 3:27 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).