From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69604C433DF for ; Fri, 22 May 2020 05:34:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 34CD82073B for ; Fri, 22 May 2020 05:34:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dPPRdln3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727781AbgEVFel (ORCPT ); Fri, 22 May 2020 01:34:41 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:54901 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725894AbgEVFel (ORCPT ); Fri, 22 May 2020 01:34:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590125678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dnQ0nMFf0h8WwglXkeiu5R/EKl0trwSByG4G+2rCYaE=; b=dPPRdln3FqEm+T6OxykFW8fr83H33F2+oeLfK782L+4mwKWnszXKx22d8jood+Ylml+56X 5cF+gnpydMOs3DRMwW5kUk3lN/GTm1Rm/gWcDp+mM4ekCX8VCzl+QJNqg9F26w4hhUHmHB W4SOwL5xJT2GzxAwgEUWGqzZT31jCGU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-199-V2GasK5KMByUJGyOtwaR9g-1; Fri, 22 May 2020 01:34:36 -0400 X-MC-Unique: V2GasK5KMByUJGyOtwaR9g-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 06A131005510; Fri, 22 May 2020 05:34:35 +0000 (UTC) Received: from kamzik.brq.redhat.com (unknown [10.40.192.87]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 58C605D9CD; Fri, 22 May 2020 05:34:27 +0000 (UTC) Date: Fri, 22 May 2020 07:34:23 +0200 From: Andrew Jones To: Jingyi Wang Cc: Zenghui Yu , kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, maz@kernel.org, wanghaibin.wang@huawei.com, eric.auger@redhat.com Subject: Re: [kvm-unit-tests PATCH 1/6] arm64: microbench: get correct ipi recieved num Message-ID: <20200522053423.cus3pnhmp4p4t3ck@kamzik.brq.redhat.com> References: <20200517100900.30792-1-wangjingyi11@huawei.com> <20200517100900.30792-2-wangjingyi11@huawei.com> <8e011659-4e4d-7312-4466-5ed3ea54cc9b@huawei.com> <8b9d51f2-3906-9e0a-38ae-564424c38ff5@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8b9d51f2-3906-9e0a-38ae-564424c38ff5@huawei.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, May 22, 2020 at 10:32:25AM +0800, Jingyi Wang wrote: > > On 5/21/2020 10:00 PM, Zenghui Yu wrote: > > On 2020/5/17 18:08, Jingyi Wang wrote: > > > If ipi_exec() fails because of timeout, we shouldn't increase > > > the number of ipi received. > > > > > > Signed-off-by: Jingyi Wang > > > --- > > >   arm/micro-bench.c | 4 +++- > > >   1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/arm/micro-bench.c b/arm/micro-bench.c > > > index 4612f41..ca022d9 100644 > > > --- a/arm/micro-bench.c > > > +++ b/arm/micro-bench.c > > > @@ -103,7 +103,9 @@ static void ipi_exec(void) > > >       while (!ipi_received && tries--) > > >           cpu_relax(); > > > -    ++received; > > > +    if (ipi_recieved) > > > > I think you may want *ipi_received* ;-) Otherwise it can not even > > compile! > > > > > +        ++received; > > > + > > >       assert_msg(ipi_received, "failed to receive IPI in time, but > > > received %d successfully\n", received); > > >   } > > > > With this fixed, this looks good to me, > > > > Reviewed-by: Zenghui Yu > > > > > > Thanks. > > > > . > This variable name is modified in the next patch, so I ignored that > mistake, thanks. > kvm-unit-tests build and run fast enough that you can do something like git rebase -i -x 'make clean && make && arm/run arm/micro-bench' to test your series before posting. Thanks, drew