From: Cornelia Huck <cohuck@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: qemu-devel@nongnu.org,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
Aurelien Jarno <aurelien@aurel32.net>,
David Hildenbrand <david@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>,
Richard Henderson <rth@twiddle.net>,
qemu-s390x@nongnu.org, David Gibson <david@gibson.dropbear.id.au>,
Peter Maydell <peter.maydell@linaro.org>,
Eduardo Habkost <ehabkost@redhat.com>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
Halil Pasic <pasic@linux.ibm.com>,
qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Thomas Huth <thuth@redhat.com>
Subject: Re: [PATCH 2/7] accel/kvm: Simplify kvm_check_extension()
Date: Tue, 23 Jun 2020 17:43:40 +0200 [thread overview]
Message-ID: <20200623174340.0dbc1989.cohuck@redhat.com> (raw)
In-Reply-To: <20200623105052.1700-3-philmd@redhat.com>
On Tue, 23 Jun 2020 12:50:47 +0200
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> In previous commit we let kvm_check_extension() use the
> global kvm_state. Since the KVMState* argument is now
> unused, drop it.
>
> Convert callers with this Coccinelle script:
>
> @@
> expression kvm_state, extension;
> @@
> - kvm_check_extension(kvm_state, extension)
> + kvm_check_extension(extension)
>
> Unused variables manually removed:
> - CPUState* in hyperv_enabled()
> - KVMState* in kvm_arm_get_max_vm_ipa_size()
>
> Inspired-by: Paolo Bonzini <pbonzini@redhat.com>
🌟💡🌟
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> include/sysemu/kvm.h | 2 +-
> accel/kvm/kvm-all.c | 64 ++++++++++++++++++------------------
> hw/hyperv/hyperv.c | 2 +-
> hw/i386/kvm/clock.c | 2 +-
> hw/i386/kvm/i8254.c | 4 +--
> hw/i386/kvm/ioapic.c | 2 +-
> hw/intc/arm_gic_kvm.c | 2 +-
> hw/intc/openpic_kvm.c | 2 +-
> hw/intc/xics_kvm.c | 2 +-
> hw/s390x/s390-stattrib-kvm.c | 2 +-
> target/arm/kvm.c | 13 ++++----
> target/arm/kvm32.c | 2 +-
> target/arm/kvm64.c | 15 ++++-----
> target/i386/kvm.c | 61 ++++++++++++++++------------------
> target/mips/kvm.c | 4 +--
> target/ppc/kvm.c | 34 +++++++++----------
> target/s390x/cpu_models.c | 3 +-
> target/s390x/kvm.c | 30 ++++++++---------
> 18 files changed, 119 insertions(+), 127 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2020-06-23 15:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 10:50 [PATCH 0/7] accel/kvm: Simplify few functions that can use global kvm_state Philippe Mathieu-Daudé
2020-06-23 10:50 ` [PATCH 1/7] accel/kvm: Let kvm_check_extension use global KVM state Philippe Mathieu-Daudé
2020-06-23 15:25 ` Cornelia Huck
2020-06-23 10:50 ` [PATCH 2/7] accel/kvm: Simplify kvm_check_extension() Philippe Mathieu-Daudé
2020-06-23 15:43 ` Cornelia Huck [this message]
2020-06-23 10:50 ` [PATCH 3/7] accel/kvm: Simplify kvm_check_extension_list() Philippe Mathieu-Daudé
2020-06-23 15:50 ` Cornelia Huck
2020-06-23 10:50 ` [RFC PATCH 4/7] accel/kvm: Simplify kvm_set_sigmask_len() Philippe Mathieu-Daudé
2020-07-05 7:12 ` Paolo Bonzini
2020-07-05 9:57 ` Philippe Mathieu-Daudé
2020-06-23 10:50 ` [PATCH 5/7] target/i386/kvm: Simplify get_para_features() Philippe Mathieu-Daudé
2020-06-23 15:56 ` Cornelia Huck
2020-06-23 10:50 ` [RFC PATCH 6/7] target/i386/kvm: Simplify kvm_get_mce_cap_supported() Philippe Mathieu-Daudé
2020-06-23 10:50 ` [RFC PATCH 7/7] target/i386/kvm: Simplify kvm_get_supported_[feature]_msrs() Philippe Mathieu-Daudé
2020-07-04 16:50 ` [PATCH 0/7] accel/kvm: Simplify few functions that can use global kvm_state Philippe Mathieu-Daudé
2020-07-05 6:16 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623174340.0dbc1989.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=aurelien@aurel32.net \
--cc=borntraeger@de.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).