Re: [PATCH 2/2] x86: Expose TSX Suspend Load Address Tracking

From: kernel test robot <lkp@intel.com>
To: Cathy Zhang <cathy.zhang@intel.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	x86@kernel.org
Cc: kbuild-all@lists.01.org, pbonzini@redhat.com,
	sean.j.christopherson@intel.com, vkuznets@redhat.com,
	wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org,
	tglx@linutronix.de
Subject: Re: [PATCH 2/2] x86: Expose TSX Suspend Load Address Tracking
Date: Tue, 7 Jul 2020 05:19:09 +0800	[thread overview]
Message-ID: <202007070554.aXOFoSkC%lkp@intel.com> (raw)
In-Reply-To: <1593989992-10019-3-git-send-email-cathy.zhang@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2985 bytes --]

Hi Cathy,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on kvm/linux-next]
[also build test ERROR on tip/auto-latest linux/master linus/master v5.8-rc4 next-20200706]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Cathy-Zhang/Expose-new-features-for-intel-processor/20200706-070640
base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
config: x86_64-rhel-7.6 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from arch/x86/kvm/cpuid.c:21:
   arch/x86/kvm/cpuid.c: In function 'kvm_set_cpu_caps':
   arch/x86/kvm/cpuid.h:91:42: error: 'X86_FEATURE_SERIALIZE' undeclared (first use in this function); did you mean 'X86_FEATURE_RETPOLINE'?
      91 | #define feature_bit(name)  __feature_bit(X86_FEATURE_##name)
         |                                          ^~~~~~~~~~~~
   arch/x86/kvm/cpuid.c:55:11: note: in expansion of macro 'feature_bit'
      55 | #define F feature_bit
         |           ^~~~~~~~~~~
   arch/x86/kvm/cpuid.c:345:3: note: in expansion of macro 'F'
     345 |   F(SERIALIZE) | F(TSX_LDTRK)
         |   ^
   arch/x86/kvm/cpuid.h:91:42: note: each undeclared identifier is reported only once for each function it appears in
      91 | #define feature_bit(name)  __feature_bit(X86_FEATURE_##name)
         |                                          ^~~~~~~~~~~~
   arch/x86/kvm/cpuid.c:55:11: note: in expansion of macro 'feature_bit'
      55 | #define F feature_bit
         |           ^~~~~~~~~~~
   arch/x86/kvm/cpuid.c:345:3: note: in expansion of macro 'F'
     345 |   F(SERIALIZE) | F(TSX_LDTRK)
         |   ^
>> arch/x86/kvm/cpuid.h:91:42: error: 'X86_FEATURE_TSX_LDTRK' undeclared (first use in this function); did you mean 'X86_FEATURE_TSC_ADJUST'?
      91 | #define feature_bit(name)  __feature_bit(X86_FEATURE_##name)
         |                                          ^~~~~~~~~~~~
   arch/x86/kvm/cpuid.c:55:11: note: in expansion of macro 'feature_bit'
      55 | #define F feature_bit
         |           ^~~~~~~~~~~
   arch/x86/kvm/cpuid.c:345:18: note: in expansion of macro 'F'
     345 |   F(SERIALIZE) | F(TSX_LDTRK)
         |                  ^

vim +91 arch/x86/kvm/cpuid.h

a0a2260c12d865 Sean Christopherson 2019-12-17  90  
87382003e35559 Sean Christopherson 2019-12-17 @91  #define feature_bit(name)  __feature_bit(X86_FEATURE_##name)
87382003e35559 Sean Christopherson 2019-12-17  92  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 49248 bytes --]