KVM Archive on lore.kernel.org
 help / color / Atom feed
From: Andrew Jones <drjones@redhat.com>
To: Jingyi Wang <wangjingyi11@huawei.com>
Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu,
	maz@kernel.org, wanghaibin.wang@huawei.com, yuzenghui@huawei.com,
	eric.auger@redhat.com, prime.zeng@hisilicon.com
Subject: Re: [kvm-unit-tests PATCH v3 09/10] arm64: microbench: Add test->post() to further process test results
Date: Sat, 1 Aug 2020 19:03:58 +0200
Message-ID: <20200801170358.lt3ssgmj5455rwt4@kamzik.brq.redhat.com> (raw)
In-Reply-To: <20200731074244.20432-10-wangjingyi11@huawei.com>

On Fri, Jul 31, 2020 at 03:42:43PM +0800, Jingyi Wang wrote:
> Under certain circumstances, we need to further process microbench
> test results, so we add test->post() in the microbench framework,
> later patch will use that.
> 
> Signed-off-by: Jingyi Wang <wangjingyi11@huawei.com>
> ---
>  arm/micro-bench.c | 31 ++++++++++++++++++-------------
>  1 file changed, 18 insertions(+), 13 deletions(-)
> 
> diff --git a/arm/micro-bench.c b/arm/micro-bench.c
> index 1e1bde5..4680ba4 100644
> --- a/arm/micro-bench.c
> +++ b/arm/micro-bench.c
> @@ -33,6 +33,12 @@ static int nr_ipi_received;
>  static void *vgic_dist_base;
>  static void (*write_eoir)(u32 irqstat);
>  
> +struct ns_time {
> +	uint64_t ns;
> +	uint64_t ns_frac;
> +};

Missing blank line

> +static void ticks_to_ns_time(uint64_t ticks, struct ns_time *ns_time);

You could have moved the whole function up here.

> +
>  static void gic_irq_handler(struct pt_regs *regs)
>  {
>  	u32 irqstat = gic_read_iar();
> @@ -283,24 +289,20 @@ struct exit_test {
>  	const char *name;
>  	bool (*prep)(void);
>  	void (*exec)(void);
> +	void (*post)(uint64_t, uint64_t, struct ns_time*);
>  	u32 times;
>  	bool run;
>  };
>  
>  static struct exit_test tests[] = {
> -	{"hvc",			NULL,		hvc_exec,		65536,		true},
> -	{"mmio_read_user",	NULL,		mmio_read_user_exec,	65536,		true},
> -	{"mmio_read_vgic",	NULL,		mmio_read_vgic_exec,	65536,		true},
> -	{"eoi",			NULL,		eoi_exec,		65536,		true},
> -	{"ipi",			ipi_prep,	ipi_exec,		65536,		true},
> -	{"ipi_hw",		ipi_hw_prep,	ipi_exec,		65536,		true},
> -	{"lpi",			lpi_prep,	lpi_exec,		65536,		true},
> -	{"timer_10ms",		timer_prep,	timer_exec,		256,		true},
> -};
> -
> -struct ns_time {
> -	uint64_t ns;
> -	uint64_t ns_frac;
> +	{"hvc",			NULL,		hvc_exec,		NULL,		65536,		true},
> +	{"mmio_read_user",	NULL,		mmio_read_user_exec,	NULL,		65536,		true},
> +	{"mmio_read_vgic",	NULL,		mmio_read_vgic_exec,	NULL,		65536,		true},
> +	{"eoi",			NULL,		eoi_exec,		NULL,		65536,		true},
> +	{"ipi",			ipi_prep,	ipi_exec,		NULL,		65536,		true},
> +	{"ipi_hw",		ipi_hw_prep,	ipi_exec,		NULL,		65536,		true},
> +	{"lpi",			lpi_prep,	lpi_exec,		NULL,		65536,		true},
> +	{"timer_10ms",		timer_prep,	timer_exec,		NULL,		256,		true},
>  };
>  
>  #define PS_PER_SEC (1000 * 1000 * 1000 * 1000UL)
> @@ -339,6 +341,9 @@ static void loop_test(struct exit_test *test)
>  		ticks_to_ns_time(total_ticks, &total_ns);
>  	}
>  
> +	if (test->post)
> +		test->post(total_ticks, ntimes, &total_ns);
> +

We can drop the ns_time structure and pass total_ticks by reference.

>  	avg_ns.ns = total_ns.ns / ntimes;
>  	avg_ns.ns_frac = total_ns.ns_frac / ntimes;
>  
> -- 
> 2.19.1
> 
>

I can do these changes myself.

Thanks,
drew


  reply index

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-31  7:42 [kvm-unit-tests PATCH v3 00/10] arm/arm64: Add IPI/LPI/vtimer latency test Jingyi Wang
2020-07-31  7:42 ` [kvm-unit-tests PATCH v3 01/10] arm64: microbench: get correct ipi received num Jingyi Wang
2020-07-31  7:42 ` [kvm-unit-tests PATCH v3 02/10] arm64: microbench: Generalize ipi test names Jingyi Wang
2020-07-31  7:42 ` [kvm-unit-tests PATCH v3 03/10] arm64: microbench: gic: Add ipi latency test for gicv4.1 support kvm Jingyi Wang
2020-07-31  7:42 ` [kvm-unit-tests PATCH v3 04/10] arm64: its: Handle its command queue wrapping Jingyi Wang
2020-07-31  7:42 ` [kvm-unit-tests PATCH v3 05/10] arm64: microbench: its: Add LPI latency test Jingyi Wang
2020-07-31  7:42 ` [kvm-unit-tests PATCH v3 06/10] arm64: microbench: Allow each test to specify its running times Jingyi Wang
2020-07-31  7:42 ` [kvm-unit-tests PATCH v3 07/10] arm64: microbench: Add time limit for each individual test Jingyi Wang
2020-08-01 16:13   ` Andrew Jones
2020-07-31  7:42 ` [kvm-unit-tests PATCH v3 08/10] arm64: microbench: Add vtimer latency test Jingyi Wang
2020-08-01 16:22   ` Andrew Jones
2020-07-31  7:42 ` [kvm-unit-tests PATCH v3 09/10] arm64: microbench: Add test->post() to further process test results Jingyi Wang
2020-08-01 17:03   ` Andrew Jones [this message]
2020-07-31  7:42 ` [kvm-unit-tests PATCH v3 10/10] arm64: microbench: Add timer_post() to get actual PPI latency Jingyi Wang
2020-07-31 12:01 ` [kvm-unit-tests PATCH v3 00/10] arm/arm64: Add IPI/LPI/vtimer latency test Andrew Jones
2020-08-03  2:15   ` Jingyi Wang
2020-08-01 17:40 ` Andrew Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200801170358.lt3ssgmj5455rwt4@kamzik.brq.redhat.com \
    --to=drjones@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=maz@kernel.org \
    --cc=prime.zeng@hisilicon.com \
    --cc=wanghaibin.wang@huawei.com \
    --cc=wangjingyi11@huawei.com \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

KVM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/kvm/0 kvm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kvm kvm/ https://lore.kernel.org/kvm \
		kvm@vger.kernel.org
	public-inbox-index kvm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.kvm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git