From: Janosch Frank <frankja@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: thuth@redhat.com, linux-s390@vger.kernel.org, david@redhat.com,
borntraeger@de.ibm.com, cohuck@redhat.com,
imbrenda@linux.ibm.com
Subject: [kvm-unit-tests PATCH v2 1/3] s390x: Add custom pgm cleanup function
Date: Fri, 7 Aug 2020 07:15:53 -0400 [thread overview]
Message-ID: <20200807111555.11169-2-frankja@linux.ibm.com> (raw)
In-Reply-To: <20200807111555.11169-1-frankja@linux.ibm.com>
Sometimes we need to do cleanup which we don't necessarily want to add
to interrupt.c, so let's add a way to register a cleanup function.
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
lib/s390x/asm/interrupt.h | 1 +
lib/s390x/interrupt.c | 12 +++++++++++-
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/lib/s390x/asm/interrupt.h b/lib/s390x/asm/interrupt.h
index 4cfade9..2772e6b 100644
--- a/lib/s390x/asm/interrupt.h
+++ b/lib/s390x/asm/interrupt.h
@@ -15,6 +15,7 @@
#define EXT_IRQ_EXTERNAL_CALL 0x1202
#define EXT_IRQ_SERVICE_SIG 0x2401
+void register_pgm_cleanup_func(void (*f)(void));
void handle_pgm_int(void);
void handle_ext_int(void);
void handle_mcck_int(void);
diff --git a/lib/s390x/interrupt.c b/lib/s390x/interrupt.c
index 243b9c2..a074505 100644
--- a/lib/s390x/interrupt.c
+++ b/lib/s390x/interrupt.c
@@ -16,6 +16,7 @@
static bool pgm_int_expected;
static bool ext_int_expected;
+static void (*pgm_cleanup_func)(void);
static struct lowcore *lc;
void expect_pgm_int(void)
@@ -51,6 +52,11 @@ void check_pgm_int_code(uint16_t code)
lc->pgm_int_code);
}
+void register_pgm_cleanup_func(void (*f)(void))
+{
+ pgm_cleanup_func = f;
+}
+
static void fixup_pgm_int(void)
{
switch (lc->pgm_int_code) {
@@ -115,7 +121,11 @@ void handle_pgm_int(void)
}
pgm_int_expected = false;
- fixup_pgm_int();
+
+ if (pgm_cleanup_func)
+ (*pgm_cleanup_func)();
+ else
+ fixup_pgm_int();
}
void handle_ext_int(void)
--
2.25.1
next prev parent reply other threads:[~2020-08-07 11:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 11:15 [kvm-unit-tests PATCH v2 0/3] PV tests part 1 Janosch Frank
2020-08-07 11:15 ` Janosch Frank [this message]
2020-08-10 12:21 ` [kvm-unit-tests PATCH v2 1/3] s390x: Add custom pgm cleanup function Cornelia Huck
2020-08-07 11:15 ` [kvm-unit-tests PATCH v2 2/3] s390x: skrf: Add exception new skey test and add test to unittests.cfg Janosch Frank
2020-08-07 12:12 ` Thomas Huth
2020-08-10 14:38 ` Cornelia Huck
2020-08-07 11:15 ` [kvm-unit-tests PATCH v2 3/3] s390x: Ultravisor guest API test Janosch Frank
2020-08-07 12:14 ` Thomas Huth
2020-08-10 14:50 ` Cornelia Huck
2020-08-10 15:27 ` Janosch Frank
2020-08-10 15:32 ` Cornelia Huck
2020-08-10 15:45 ` [kvm-unit-tests PATCH v3] " Janosch Frank
2020-08-10 15:50 ` Cornelia Huck
2020-08-11 7:18 ` Janosch Frank
2020-08-11 7:29 ` [kvm-unit-tests PATCH v2 0/3] PV tests part 1 Janosch Frank
-- strict thread matches above, loose matches on Subject: below --
2020-07-27 9:54 Janosch Frank
2020-07-27 9:54 ` [kvm-unit-tests PATCH v2 1/3] s390x: Add custom pgm cleanup function Janosch Frank
2020-07-30 10:53 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200807111555.11169-2-frankja@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).