From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3907BC433DF for ; Mon, 10 Aug 2020 14:38:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0AD1E2070B for ; Mon, 10 Aug 2020 14:38:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LbCI7g4M" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726111AbgHJOix (ORCPT ); Mon, 10 Aug 2020 10:38:53 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:47465 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726436AbgHJOiw (ORCPT ); Mon, 10 Aug 2020 10:38:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597070332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=owTQ/60W4cl8k08yaQREW3e0LvIAZEObqjO56lvs13E=; b=LbCI7g4MlXUInLSXHBRg5AAovVqLQO9NiXsS7IgAfPuV17hRtm/eIcls8T/S4Xf+OXqSZR OnVv3U16VNFd5sNLada/i3rOr8hiar2eWbPEQhWY89V57Av5GjnSE+GgtXRoJFC/jK4NGE OgO/Hw4eeCiRCeTkT15ihjYWgbT4U/o= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-381-cLOIpDELM7yIxRV7lePCCA-1; Mon, 10 Aug 2020 10:38:48 -0400 X-MC-Unique: cLOIpDELM7yIxRV7lePCCA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 187638015F4; Mon, 10 Aug 2020 14:38:47 +0000 (UTC) Received: from gondolin (ovpn-112-218.ams2.redhat.com [10.36.112.218]) by smtp.corp.redhat.com (Postfix) with ESMTP id AEAA38AC2D; Mon, 10 Aug 2020 14:38:42 +0000 (UTC) Date: Mon, 10 Aug 2020 16:38:40 +0200 From: Cornelia Huck To: Janosch Frank Cc: kvm@vger.kernel.org, thuth@redhat.com, linux-s390@vger.kernel.org, david@redhat.com, borntraeger@de.ibm.com, imbrenda@linux.ibm.com Subject: Re: [kvm-unit-tests PATCH v2 2/3] s390x: skrf: Add exception new skey test and add test to unittests.cfg Message-ID: <20200810163840.1eebeeb3.cohuck@redhat.com> In-Reply-To: <20200807111555.11169-3-frankja@linux.ibm.com> References: <20200807111555.11169-1-frankja@linux.ibm.com> <20200807111555.11169-3-frankja@linux.ibm.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, 7 Aug 2020 07:15:54 -0400 Janosch Frank wrote: > When an exception new psw with a storage key in its mask is loaded > from lowcore, a specification exception is raised. This differs from > the behavior when trying to execute skey related instructions, which > will result in special operation exceptions. > > Also let's add the test to unittests.cfg so it is run more often. > > Signed-off-by: Janosch Frank > Reviewed-by: Claudio Imbrenda > --- > s390x/skrf.c | 79 +++++++++++++++++++++++++++++++++++++++++++++ > s390x/unittests.cfg | 4 +++ > 2 files changed, 83 insertions(+) Didn't review deeply. Acked-by: Cornelia Huck