From: Andrew Jones <drjones@redhat.com>
To: Marc Hartmayer <mhartmay@linux.ibm.com>
Cc: kvm@vger.kernel.org, Thomas Huth <thuth@redhat.com>,
David Hildenbrand <david@redhat.com>,
Janosch Frank <frankja@linux.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux-s390@vger.kernel.org
Subject: Re: [kvm-unit-tests RFC v2 1/4] common.bash: run `cmd` only if a test case was found
Date: Thu, 13 Aug 2020 09:40:59 +0200 [thread overview]
Message-ID: <20200813074059.y4qvrne5thm2olf2@kamzik.brq.redhat.com> (raw)
In-Reply-To: <20200812092705.17774-2-mhartmay@linux.ibm.com>
On Wed, Aug 12, 2020 at 11:27:02AM +0200, Marc Hartmayer wrote:
> It's only useful to run `cmd` in `for_each_unittest` if a test case
> was found. This change allows us to remove the guards from the
> functions `run_task` and `mkstandalone`.
>
> Signed-off-by: Marc Hartmayer <mhartmay@linux.ibm.com>
> ---
> run_tests.sh | 3 ---
> scripts/common.bash | 8 ++++++--
> scripts/mkstandalone.sh | 4 ----
> 3 files changed, 6 insertions(+), 9 deletions(-)
>
Reviewed-by: Andrew Jones <drjones@redhat.com>
next prev parent reply other threads:[~2020-08-13 7:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 9:27 [kvm-unit-tests RFC v2 0/4] s390x: Add Protected VM support Marc Hartmayer
2020-08-12 9:27 ` [kvm-unit-tests RFC v2 1/4] common.bash: run `cmd` only if a test case was found Marc Hartmayer
2020-08-13 7:40 ` Andrew Jones [this message]
2020-08-13 11:37 ` Marc Hartmayer
2020-08-12 9:27 ` [kvm-unit-tests RFC v2 2/4] scripts: add support for architecture dependent functions Marc Hartmayer
2020-08-13 7:49 ` Andrew Jones
2020-08-13 11:45 ` Marc Hartmayer
2020-08-13 12:07 ` Andrew Jones
2020-08-13 12:36 ` Marc Hartmayer
2020-08-12 9:27 ` [kvm-unit-tests RFC v2 3/4] run_tests/mkstandalone: add arch dependent function to `for_each_unittest` Marc Hartmayer
2020-08-13 8:30 ` Andrew Jones
2020-08-14 13:06 ` Marc Hartmayer
2020-08-14 13:29 ` Andrew Jones
2020-08-18 9:03 ` Marc Hartmayer
2020-08-18 9:13 ` Andrew Jones
2020-08-12 9:27 ` [kvm-unit-tests RFC v2 4/4] s390x: add Protected VM support Marc Hartmayer
2020-08-13 11:56 ` Cornelia Huck
2020-08-13 13:08 ` Marc Hartmayer
2020-08-13 14:22 ` Cornelia Huck
2020-08-13 15:13 ` Marc Hartmayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813074059.y4qvrne5thm2olf2@kamzik.brq.redhat.com \
--to=drjones@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mhartmay@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).