KVM Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] KVM: SVM: Get rid of the variable 'exit_fastpath'
@ 2020-09-15 11:30 lihaiwei.kernel
  2020-09-15 17:58 ` Krish Sadhukhan
  0 siblings, 1 reply; 2+ messages in thread
From: lihaiwei.kernel @ 2020-09-15 11:30 UTC (permalink / raw)
  To: x86, kvm, linux-kernel
  Cc: pbonzini, sean.j.christopherson, vkuznets, wanpengli, jmattson,
	joro, tglx, hpa, Haiwei Li, Krish Sadhukhan

From: Haiwei Li <lihaiwei@tencent.com>

'exit_fastpath' isn't used anywhere else, so remove it.

Suggested-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
Signed-off-by: Haiwei Li <lihaiwei@tencent.com>
---
 arch/x86/kvm/svm/svm.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
index c44f3e9..6e88658 100644
--- a/arch/x86/kvm/svm/svm.c
+++ b/arch/x86/kvm/svm/svm.c
@@ -3413,7 +3413,6 @@ static noinstr void svm_vcpu_enter_exit(struct kvm_vcpu *vcpu,
 
 static __no_kcsan fastpath_t svm_vcpu_run(struct kvm_vcpu *vcpu)
 {
-	fastpath_t exit_fastpath;
 	struct vcpu_svm *svm = to_svm(vcpu);
 
 	svm->vmcb->save.rax = vcpu->arch.regs[VCPU_REGS_RAX];
@@ -3536,8 +3535,7 @@ static __no_kcsan fastpath_t svm_vcpu_run(struct kvm_vcpu *vcpu)
 		svm_handle_mce(svm);
 
 	svm_complete_interrupts(svm);
-	exit_fastpath = svm_exit_handlers_fastpath(vcpu);
-	return exit_fastpath;
+	return svm_exit_handlers_fastpath(vcpu);
 }
 
 static void svm_load_mmu_pgd(struct kvm_vcpu *vcpu, unsigned long root,
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] KVM: SVM: Get rid of the variable 'exit_fastpath'
  2020-09-15 11:30 [PATCH] KVM: SVM: Get rid of the variable 'exit_fastpath' lihaiwei.kernel
@ 2020-09-15 17:58 ` Krish Sadhukhan
  0 siblings, 0 replies; 2+ messages in thread
From: Krish Sadhukhan @ 2020-09-15 17:58 UTC (permalink / raw)
  To: lihaiwei.kernel, x86, kvm, linux-kernel
  Cc: pbonzini, sean.j.christopherson, vkuznets, wanpengli, jmattson,
	joro, tglx, hpa, Haiwei Li


On 9/15/20 4:30 AM, lihaiwei.kernel@gmail.com wrote:
> From: Haiwei Li <lihaiwei@tencent.com>
>
> 'exit_fastpath' isn't used anywhere else, so remove it.
>
> Suggested-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
> Signed-off-by: Haiwei Li <lihaiwei@tencent.com>
> ---
>   arch/x86/kvm/svm/svm.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
> index c44f3e9..6e88658 100644
> --- a/arch/x86/kvm/svm/svm.c
> +++ b/arch/x86/kvm/svm/svm.c
> @@ -3413,7 +3413,6 @@ static noinstr void svm_vcpu_enter_exit(struct kvm_vcpu *vcpu,
>   
>   static __no_kcsan fastpath_t svm_vcpu_run(struct kvm_vcpu *vcpu)
>   {
> -	fastpath_t exit_fastpath;
>   	struct vcpu_svm *svm = to_svm(vcpu);
>   
>   	svm->vmcb->save.rax = vcpu->arch.regs[VCPU_REGS_RAX];
> @@ -3536,8 +3535,7 @@ static __no_kcsan fastpath_t svm_vcpu_run(struct kvm_vcpu *vcpu)
>   		svm_handle_mce(svm);
>   
>   	svm_complete_interrupts(svm);
> -	exit_fastpath = svm_exit_handlers_fastpath(vcpu);
> -	return exit_fastpath;
> +	return svm_exit_handlers_fastpath(vcpu);
>   }
>   
>   static void svm_load_mmu_pgd(struct kvm_vcpu *vcpu, unsigned long root,
Reviewed-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-15 11:30 [PATCH] KVM: SVM: Get rid of the variable 'exit_fastpath' lihaiwei.kernel
2020-09-15 17:58 ` Krish Sadhukhan

KVM Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/kvm/0 kvm/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 kvm kvm/ https://lore.kernel.org/kvm \
		kvm@vger.kernel.org
	public-inbox-index kvm

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.kvm


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git