From: Zhenyu Wang <zhenyuw@linux.intel.com>
To: Fred Gao <fred.gao@intel.com>
Cc: kvm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
Xiong Zhang <xiong.y.zhang@intel.com>,
Hang Yuan <hang.yuan@linux.intel.com>,
Stuart Summers <stuart.summers@intel.com>,
Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [PATCH v2] vfio/pci: Refine Intel IGD OpRegion support
Date: Tue, 29 Sep 2020 16:49:26 +0800 [thread overview]
Message-ID: <20200929084926.GH27141@zhen-hp.sh.intel.com> (raw)
In-Reply-To: <20200929161038.15465-1-fred.gao@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1748 bytes --]
On 2020.09.30 00:10:38 +0800, Fred Gao wrote:
> Bypass the IGD initialization for Intel's dgfx devices with own expansion
> ROM and the host/LPC bridge config space are no longer accessed.
>
> v2: simply test if discrete or integrated gfx device
> with root bus. (Alex Williamson)
>
Patch title is somehow misleading that better change to what this one does
that skip VFIO IGD setup for Intel discrete graphics card.
With that,
Reviewed-by: Zhenyu Wang <zhenyuw@linux.intel.com>
> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> Cc: Xiong Zhang <xiong.y.zhang@intel.com>
> Cc: Hang Yuan <hang.yuan@linux.intel.com>
> Cc: Stuart Summers <stuart.summers@intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> Signed-off-by: Fred Gao <fred.gao@intel.com>
> ---
> drivers/vfio/pci/vfio_pci.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/vfio/pci/vfio_pci.c b/drivers/vfio/pci/vfio_pci.c
> index f634c81998bb..9258ccfadb79 100644
> --- a/drivers/vfio/pci/vfio_pci.c
> +++ b/drivers/vfio/pci/vfio_pci.c
> @@ -336,10 +336,11 @@ static int vfio_pci_enable(struct vfio_pci_device *vdev)
> if (!vfio_vga_disabled() && vfio_pci_is_vga(pdev))
> vdev->has_vga = true;
>
> -
> + /* Intel's dgfx should not appear on root bus */
> if (vfio_pci_is_vga(pdev) &&
> pdev->vendor == PCI_VENDOR_ID_INTEL &&
> - IS_ENABLED(CONFIG_VFIO_PCI_IGD)) {
> + IS_ENABLED(CONFIG_VFIO_PCI_IGD) &&
> + pci_is_root_bus(pdev->bus)) {
> ret = vfio_pci_igd_init(vdev);
> if (ret) {
> pci_warn(pdev, "Failed to setup Intel IGD regions\n");
> --
> 2.24.1.1.gb6d4d82bd5
>
--
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2020-09-29 9:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 16:10 [PATCH v2] vfio/pci: Refine Intel IGD OpRegion support Fred Gao
2020-09-29 8:49 ` Zhenyu Wang [this message]
2020-09-29 22:06 ` Alex Williamson
2020-11-02 18:01 ` [PATCH v3] vfio/pci: Bypass IGD init in case of -ENODEV Fred Gao
2020-11-03 18:21 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929084926.GH27141@zhen-hp.sh.intel.com \
--to=zhenyuw@linux.intel.com \
--cc=fred.gao@intel.com \
--cc=hang.yuan@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kvm@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=stuart.summers@intel.com \
--cc=xiong.y.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).