From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9227C838D1 for ; Tue, 27 Oct 2020 15:48:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7CED42231B for ; Tue, 27 Oct 2020 15:48:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WKldZ05u" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1800536AbgJ0Pr6 (ORCPT ); Tue, 27 Oct 2020 11:47:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:45451 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1798551AbgJ0P2w (ORCPT ); Tue, 27 Oct 2020 11:28:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603812531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mlWO+8V1OcYguip2KBsMhYWBSFJwL/+zUDmEZaIbfJ4=; b=WKldZ05uRRnd7jfUDf+eXY82dU6qVMRserWCR3AQCKsYULu3T/y8B1yqIJaoitr6iizuYf Hx7lIZ9x8eFNLDGBeLFdrw9z15q1vuarALmscrBIZPINoUz/eJ8klX323OFv0aC1cstaWE Yh5Pr3+u/a7yyxYmFlfv0y6WmGdUXC4= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-417-G-acPPXSPomC_ZT_BAJPDA-1; Tue, 27 Oct 2020 11:28:48 -0400 X-MC-Unique: G-acPPXSPomC_ZT_BAJPDA-1 Received: by mail-wr1-f71.google.com with SMTP id n14so908488wrp.1 for ; Tue, 27 Oct 2020 08:28:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mlWO+8V1OcYguip2KBsMhYWBSFJwL/+zUDmEZaIbfJ4=; b=KuwjJ3NVj3XE/Iupl4JNKUPTHnxlm5W6Yg/JkBffMIfgJUZ0j4cMycjr/VnGBuZ3xQ oGK9jAL75jK9h2wvIrvQs+QdiFzQbYzlSkhNc7/K01vH9Q7kFYZZl9A9ZianJ6+btGU6 Etk14n2JUneGLnf2DiWlmp4LW4BIrPttEccl2KfmAEg+SxDHB/ROIUjDAQJl3WuFdOFx NILcEWdqnGLgqK8xjNQBKQmcMNqPI9SMIsCfiKPe6haeaCb+xYf3VEs5IU7v2FH5u4j2 +bXjcrKYAdpAHCPA2yDW3uXTqVENJRtDbBTm8rFC4OmBjYQeEY4xdsaFH7mtSK+ZGa5E SDPQ== X-Gm-Message-State: AOAM532EWkk7agrb10iAISG/TMZp2N3vClf/MV4DuGPNkN7yqichTr6/ Z0AVDGL742QHIzEO01k7m+uJXRkRlruvBqX8UvAztzLxjYpPpsIUyCGnbRsZHLQO9kZNwSox2di Tn7e8prHv0yhw X-Received: by 2002:a1c:2cd7:: with SMTP id s206mr3177565wms.182.1603812526989; Tue, 27 Oct 2020 08:28:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuH3n7lQ9eR5dnqf6yc1oFeHmyleXhbTjubsRyj6zs3Jak/y/oaUl12gqM18qHQ8tFGKD6AA== X-Received: by 2002:a1c:2cd7:: with SMTP id s206mr3177537wms.182.1603812526789; Tue, 27 Oct 2020 08:28:46 -0700 (PDT) Received: from redhat.com (bzq-109-65-21-184.red.bezeqint.net. [109.65.21.184]) by smtp.gmail.com with ESMTPSA id 3sm2370433wmd.19.2020.10.27.08.28.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2020 08:28:45 -0700 (PDT) Date: Tue, 27 Oct 2020 11:28:40 -0400 From: "Michael S. Tsirkin" To: Bartosz Golaszewski Cc: Andy Shevchenko , Sumit Semwal , Gustavo Padovan , Christian =?iso-8859-1?Q?K=F6nig?= , Mauro Carvalho Chehab , Borislav Petkov , Tony Luck , James Morse , Robert Richter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Alexander Shishkin , Linus Walleij , Jason Wang , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Jaroslav Kysela , Takashi Iwai , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-gpio@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-mm@kvack.org, alsa-devel@alsa-project.org, Bartosz Golaszewski Subject: Re: [PATCH 3/8] vhost: vringh: use krealloc_array() Message-ID: <20201027112607-mutt-send-email-mst@kernel.org> References: <20201027121725.24660-1-brgl@bgdev.pl> <20201027121725.24660-4-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201027121725.24660-4-brgl@bgdev.pl> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Oct 27, 2020 at 01:17:20PM +0100, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Use the helper that checks for overflows internally instead of manually > calculating the size of the new array. > > Signed-off-by: Bartosz Golaszewski No problem with the patch, it does introduce some symmetry in the code. Acked-by: Michael S. Tsirkin > --- > drivers/vhost/vringh.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/vhost/vringh.c b/drivers/vhost/vringh.c > index 8bd8b403f087..08a0e1c842df 100644 > --- a/drivers/vhost/vringh.c > +++ b/drivers/vhost/vringh.c > @@ -198,7 +198,8 @@ static int resize_iovec(struct vringh_kiov *iov, gfp_t gfp) > > flag = (iov->max_num & VRINGH_IOV_ALLOCATED); > if (flag) > - new = krealloc(iov->iov, new_num * sizeof(struct iovec), gfp); > + new = krealloc_array(iov->iov, new_num, > + sizeof(struct iovec), gfp); > else { > new = kmalloc_array(new_num, sizeof(struct iovec), gfp); > if (new) { > -- > 2.29.1