From: Stefano Garzarella <sgarzare@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: mst@redhat.com, netdev@vger.kernel.org,
Stefan Hajnoczi <stefanha@redhat.com>,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vhost/vsock: add IOTLB API support
Date: Fri, 30 Oct 2020 11:54:22 +0100 [thread overview]
Message-ID: <20201030105422.ju2aj2bmwsckdufh@steredhat> (raw)
In-Reply-To: <751cc074-ae68-72c8-71de-a42458058761@redhat.com>
On Fri, Oct 30, 2020 at 06:02:18PM +0800, Jason Wang wrote:
>
>On 2020/10/30 上午1:43, Stefano Garzarella wrote:
>>This patch enables the IOTLB API support for vhost-vsock devices,
>>allowing the userspace to emulate an IOMMU for the guest.
>>
>>These changes were made following vhost-net, in details this patch:
>>- exposes VIRTIO_F_ACCESS_PLATFORM feature and inits the iotlb
>> device if the feature is acked
>>- implements VHOST_GET_BACKEND_FEATURES and
>> VHOST_SET_BACKEND_FEATURES ioctls
>>- calls vq_meta_prefetch() before vq processing to prefetch vq
>> metadata address in IOTLB
>>- provides .read_iter, .write_iter, and .poll callbacks for the
>> chardev; they are used by the userspace to exchange IOTLB messages
>>
>>This patch was tested with QEMU and a patch applied [1] to fix a
>>simple issue:
>> $ qemu -M q35,accel=kvm,kernel-irqchip=split \
>> -drive file=fedora.qcow2,format=qcow2,if=virtio \
>> -device intel-iommu,intremap=on \
>> -device vhost-vsock-pci,guest-cid=3,iommu_platform=on
>
>
>Patch looks good, but a question:
>
>It looks to me you don't enable ATS which means vhost won't get any
>invalidation request or did I miss anything?
>
You're right, I didn't see invalidation requests, only miss and updates.
Now I have tried to enable 'ats' and 'device-iotlb' but I still don't
see any invalidation.
How can I test it? (Sorry but I don't have much experience yet with
vIOMMU)
Thanks,
Stefano
next prev parent reply other threads:[~2020-10-30 10:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 17:43 [PATCH] vhost/vsock: add IOTLB API support Stefano Garzarella
2020-10-30 9:10 ` Stefan Hajnoczi
2020-10-30 10:02 ` Jason Wang
2020-10-30 10:54 ` Stefano Garzarella [this message]
2020-10-30 11:44 ` Jason Wang
2020-10-30 16:19 ` Stefano Garzarella
2020-11-02 17:11 ` Stefano Garzarella
2020-11-03 9:04 ` Jason Wang
2020-11-03 19:46 ` Peter Xu
2020-11-04 9:33 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030105422.ju2aj2bmwsckdufh@steredhat \
--to=sgarzare@redhat.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).