From: Peter Xu <peterx@redhat.com>
To: Ben Gardon <bgardon@google.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
Andrew Jones <drjones@redhat.com>,
Peter Shier <pshier@google.com>,
Sean Christopherson <sean.j.christopherson@intel.com>,
Thomas Huth <thuth@redhat.com>, Peter Feiner <pfeiner@google.com>
Subject: Re: [PATCH 1/5] KVM: selftests: Factor code out of demand_paging_test
Date: Mon, 2 Nov 2020 16:23:58 -0500 [thread overview]
Message-ID: <20201102212358.GB20600@xz-x1> (raw)
In-Reply-To: <20201027233733.1484855-2-bgardon@google.com>
On Tue, Oct 27, 2020 at 04:37:29PM -0700, Ben Gardon wrote:
> Much of the code in demand_paging_test can be reused by other, similar
> multi-vCPU-memory-touching-perfromance-tests. Factor that common code
> out for reuse.
>
> No functional change expected.
Is there explicit reason to put the common code in a header rather than
perf_test_util.c? No strong opinion on this especially this is test code,
just curious. Since iiuc .c file is still preferred for things like this.
>
> This series was tested by running the following invocations on an Intel
> Skylake machine:
> dirty_log_perf_test -b 20m -i 100 -v 64
> dirty_log_perf_test -b 20g -i 5 -v 4
> dirty_log_perf_test -b 4g -i 5 -v 32
> demand_paging_test -b 20m -v 64
> demand_paging_test -b 20g -v 4
> demand_paging_test -b 4g -v 32
> All behaved as expected.
May move this chunk to the cover letter to avoid keeping it in every commit
(btw, you mentioned "this series" but I feel like you meant "you verified that
after applying each of the commits").
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2020-11-02 21:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 23:37 [PATCH 0/5] Add a dirty logging performance test Ben Gardon
2020-10-27 23:37 ` [PATCH 1/5] KVM: selftests: Factor code out of demand_paging_test Ben Gardon
2020-11-02 21:23 ` Peter Xu [this message]
2020-11-02 22:57 ` Ben Gardon
2020-10-27 23:37 ` [PATCH 2/5] KVM: selftests: Remove address rounding in guest code Ben Gardon
2020-11-02 21:25 ` Peter Xu
2020-10-27 23:37 ` [PATCH 3/5] KVM: selftests: Simplify demand_paging_test with timespec_diff_now Ben Gardon
2020-11-02 21:27 ` Peter Xu
2020-11-02 22:59 ` Ben Gardon
2020-10-27 23:37 ` [PATCH 4/5] KVM: selftests: Add wrfract to common guest code Ben Gardon
2020-10-27 23:37 ` [PATCH 5/5] KVM: selftests: Introduce the dirty log perf test Ben Gardon
2020-11-02 22:21 ` Peter Xu
2020-11-02 23:56 ` Ben Gardon
2020-11-03 1:12 ` Peter Xu
2020-11-03 22:17 ` Ben Gardon
2020-11-03 22:27 ` Peter Xu
2020-11-06 12:48 ` [PATCH 0/5] Add a dirty logging performance test Paolo Bonzini
2020-11-09 9:21 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102212358.GB20600@xz-x1 \
--to=peterx@redhat.com \
--cc=bgardon@google.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=pfeiner@google.com \
--cc=pshier@google.com \
--cc=sean.j.christopherson@intel.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).