From: Andrew Jones <drjones@redhat.com>
To: Nikos Nikoleris <nikos.nikoleris@arm.com>
Cc: kvm@vger.kernel.org, mark.rutland@arm.com, jade.alglave@arm.com,
luc.maranget@inria.fr, andre.przywara@arm.com,
alexandru.elisei@arm.com
Subject: Re: [kvm-unit-tests PATCH 2/2] arm: Add support for the DEVICE_nGRE and NORMAL_WT memory types
Date: Tue, 3 Nov 2020 18:10:27 +0100 [thread overview]
Message-ID: <20201103171027.jl7lrgp4bht4peo2@kamzik.brq.redhat.com> (raw)
In-Reply-To: <20201102115311.103750-3-nikos.nikoleris@arm.com>
On Mon, Nov 02, 2020 at 11:53:11AM +0000, Nikos Nikoleris wrote:
> Signed-off-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
> ---
> lib/arm64/asm/pgtable-hwdef.h | 2 ++
> arm/cstart64.S | 6 +++++-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/lib/arm64/asm/pgtable-hwdef.h b/lib/arm64/asm/pgtable-hwdef.h
> index 3b6b0d6..16b59ba 100644
> --- a/lib/arm64/asm/pgtable-hwdef.h
> +++ b/lib/arm64/asm/pgtable-hwdef.h
> @@ -143,5 +143,7 @@
> #define MT_DEVICE_GRE 2
> #define MT_NORMAL_NC 3 /* writecombine */
> #define MT_NORMAL 4
> +#define MT_NORMAL_WT 5
> +#define MT_DEVICE_nGRE 6
>
> #endif /* _ASMARM64_PGTABLE_HWDEF_H_ */
> diff --git a/arm/cstart64.S b/arm/cstart64.S
> index cedc678..540994d 100644
> --- a/arm/cstart64.S
> +++ b/arm/cstart64.S
> @@ -154,6 +154,8 @@ halt:
> * DEVICE_GRE 010 00001100
> * NORMAL_NC 011 01000100
> * NORMAL 100 11111111
> + * NORMAL_WT 101 10111011
> + * DEVICE_nGRE 110 00001000
> */
> #define MAIR(attr, mt) ((attr) << ((mt) * 8))
>
> @@ -184,7 +186,9 @@ asm_mmu_enable:
> MAIR(0x04, MT_DEVICE_nGnRE) | \
> MAIR(0x0c, MT_DEVICE_GRE) | \
> MAIR(0x44, MT_NORMAL_NC) | \
> - MAIR(0xff, MT_NORMAL)
> + MAIR(0xff, MT_NORMAL) | \
> + MAIR(0xbb, MT_NORMAL_WT) | \
> + MAIR(0x08, MT_DEVICE_nGRE)
> msr mair_el1, x1
>
> /* TTBR0 */
> --
> 2.17.1
>
Reviewed-by: Andrew Jones <drjones@redhat.com>
next prev parent reply other threads:[~2020-11-03 17:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 11:53 [kvm-unit-tests PATCH 0/2] arm: MMU extentions to enable litmus7 Nikos Nikoleris
2020-11-02 11:53 ` [kvm-unit-tests PATCH 1/2] arm: Add mmu_get_pte() to the MMU API Nikos Nikoleris
2020-11-03 17:10 ` Andrew Jones
2020-11-05 14:27 ` Alexandru Elisei
2020-11-07 11:01 ` Nikos Nikoleris
2020-11-09 12:36 ` Alexandru Elisei
2020-11-09 12:49 ` Andrew Jones
2020-11-02 11:53 ` [kvm-unit-tests PATCH 2/2] arm: Add support for the DEVICE_nGRE and NORMAL_WT memory types Nikos Nikoleris
2020-11-03 17:10 ` Andrew Jones [this message]
2020-11-03 17:09 ` [kvm-unit-tests PATCH 0/2] arm: MMU extentions to enable litmus7 Andrew Jones
2020-11-03 17:17 ` Nikos Nikoleris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103171027.jl7lrgp4bht4peo2@kamzik.brq.redhat.com \
--to=drjones@redhat.com \
--cc=alexandru.elisei@arm.com \
--cc=andre.przywara@arm.com \
--cc=jade.alglave@arm.com \
--cc=kvm@vger.kernel.org \
--cc=luc.maranget@inria.fr \
--cc=mark.rutland@arm.com \
--cc=nikos.nikoleris@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).