From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28C6DC388F7 for ; Wed, 4 Nov 2020 10:55:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6757223BD for ; Wed, 4 Nov 2020 10:55:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KXzceQA7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729307AbgKDKzD (ORCPT ); Wed, 4 Nov 2020 05:55:03 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:55963 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726410AbgKDKzD (ORCPT ); Wed, 4 Nov 2020 05:55:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604487302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q3u0+lkwsfiVe4d5JwGEYaEFEFtHacqRJXTy/nsAlx0=; b=KXzceQA7PvoP07L6Ul+NW4QogAn9wEirwrbzMFJrTHnh+k3GUT0sRqFloGeDzHvSzdKz/M kaanUoYgYwbGDvbYrbkHsBxAbT8u5VJp6AjmuUo7uy7PEA2nM+ltrnmlql/VKUulF4Hs7N oVR00ueshC91L21xWQeM3cE5dlVd3F4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-570-m8B7P33NNe-Xsxrs1Gxuww-1; Wed, 04 Nov 2020 05:55:00 -0500 X-MC-Unique: m8B7P33NNe-Xsxrs1Gxuww-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 724DE8030D7; Wed, 4 Nov 2020 10:54:59 +0000 (UTC) Received: from kamzik.brq.redhat.com (unknown [10.40.192.66]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 28C655B4BB; Wed, 4 Nov 2020 10:54:52 +0000 (UTC) Date: Wed, 4 Nov 2020 11:54:50 +0100 From: Andrew Jones To: Ben Gardon Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, Paolo Bonzini , Peter Xu , Peter Shier , Sean Christopherson , Thomas Huth , Peter Feiner Subject: Re: [PATCH v2 1/5] KVM: selftests: Remove address rounding in guest code Message-ID: <20201104105450.t2frosra4mvixrwi@kamzik.brq.redhat.com> References: <20201103234952.1626730-1-bgardon@google.com> <20201103234952.1626730-2-bgardon@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201103234952.1626730-2-bgardon@google.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Nov 03, 2020 at 03:49:48PM -0800, Ben Gardon wrote: > Rounding the address the guest writes to a host page boundary > will only have an effect if the host page size is larger than the guest > page size, but in that case the guest write would still go to the same > host page. There's no reason to round the address down, so remove the > rounding to simplify the demand paging test. > > Signed-off-by: Ben Gardon > --- > tools/testing/selftests/kvm/demand_paging_test.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tools/testing/selftests/kvm/demand_paging_test.c b/tools/testing/selftests/kvm/demand_paging_test.c > index 360cd3ea4cd67..32a42eafc6b5c 100644 > --- a/tools/testing/selftests/kvm/demand_paging_test.c > +++ b/tools/testing/selftests/kvm/demand_paging_test.c > @@ -103,7 +103,6 @@ static void guest_code(uint32_t vcpu_id) > for (i = 0; i < pages; i++) { > uint64_t addr = gva + (i * guest_page_size); > > - addr &= ~(host_page_size - 1); > *(uint64_t *)addr = 0x0123456789ABCDEF; > } > > -- > 2.29.1.341.ge80a0c044ae-goog > Reviewed-by: Andrew Jones