From: Jessica Yu <jeyu@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Dexuan Cui <decui@microsoft.com>, Ingo Molnar <mingo@kernel.org>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: static_branch_enable() does not work from a __init function?
Date: Wed, 16 Dec 2020 14:27:42 +0100 [thread overview]
Message-ID: <20201216132742.GD13751@linux-8ccs> (raw)
In-Reply-To: <20201216132312.GA3021@hirez.programming.kicks-ass.net>
+++ Peter Zijlstra [16/12/20 14:23 +0100]:
>On Wed, Dec 16, 2020 at 02:10:16PM +0100, Jessica Yu wrote:
>> +++ Peter Zijlstra [16/12/20 13:47 +0100]:
>
>> > Only because we're having .init=false, incorrectly. See the other email.
>>
>> Ah yeah, you're right. I also misread the intention of the if
>> conditional :/ If we're currently running an init function it's fine,
>> but after that it will be unsafe.
>
>Exactly, seeing how it'll end up being freed and such ;-)
>
>> Btw, your patch seems to work for me, using the test module provided
>> by Dexuan.
>
>Ah, excellent. I couldn't be bothered to figure out how to build a
>module ;-)
>
>I'll add your Tested-by and go queue it for /urgent I suppose.
That's fine by me :-)
Tested-by: Jessica Yu <jeyu@kernel.org>
next prev parent reply other threads:[~2020-12-16 13:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 3:54 static_branch_enable() does not work from a __init function? Dexuan Cui
2020-12-16 9:26 ` Peter Zijlstra
2020-12-16 10:59 ` Peter Zijlstra
2020-12-16 13:30 ` [RFC][PATCH] jump_label/static_call: Add MAINTAINERS Peter Zijlstra
2020-12-16 13:42 ` Peter Zijlstra
2020-12-16 14:23 ` Steven Rostedt
2020-12-16 16:19 ` Josh Poimboeuf
2020-12-16 16:19 ` Ard Biesheuvel
2020-12-16 21:16 ` Jason Baron
2020-12-16 13:54 ` [PATCH] jump_label: Fix usage in module __init Peter Zijlstra
2020-12-16 16:36 ` Josh Poimboeuf
2020-12-16 20:45 ` static_branch_enable() does not work from a __init function? Dexuan Cui
2020-12-16 11:55 ` Jessica Yu
2020-12-16 12:47 ` Peter Zijlstra
2020-12-16 13:10 ` Jessica Yu
2020-12-16 13:23 ` Peter Zijlstra
2020-12-16 13:27 ` Jessica Yu [this message]
2020-12-16 12:38 ` Jessica Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201216132742.GD13751@linux-8ccs \
--to=jeyu@kernel.org \
--cc=bristot@redhat.com \
--cc=decui@microsoft.com \
--cc=jpoimboe@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).