From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Greg Kurz <groug@kaod.org>,
David Gibson <david@gibson.dropbear.id.au>,
pair@us.ibm.com, brijesh.singh@amd.com, frankja@linux.ibm.com,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
david@redhat.com, qemu-devel@nongnu.org, pasic@linux.ibm.com,
borntraeger@de.ibm.com, qemu-s390x@nongnu.org,
qemu-ppc@nongnu.org, berrange@redhat.com,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
thuth@redhat.com, pbonzini@redhat.com, rth@twiddle.net,
mdroth@linux.vnet.ibm.com, Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration
Date: Fri, 18 Dec 2020 12:08:36 +0000 [thread overview]
Message-ID: <20201218120836.GA2956@work-vm> (raw)
In-Reply-To: <20201218124111.4957eb50.cohuck@redhat.com>
* Cornelia Huck (cohuck@redhat.com) wrote:
> On Thu, 17 Dec 2020 15:15:30 +0100
> Greg Kurz <groug@kaod.org> wrote:
>
> > On Thu, 17 Dec 2020 12:38:42 +0100
> > Cornelia Huck <cohuck@redhat.com> wrote:
> >
> > > On Thu, 17 Dec 2020 16:47:36 +1100
> > > David Gibson <david@gibson.dropbear.id.au> wrote:
> > >
> > > > On Mon, Dec 14, 2020 at 06:22:40PM +0100, Cornelia Huck wrote:
> > > > > On Fri, 4 Dec 2020 16:44:13 +1100
> > > > > David Gibson <david@gibson.dropbear.id.au> wrote:
> > > > >
> > > > > > We haven't yet implemented the fairly involved handshaking that will be
> > > > > > needed to migrate PEF protected guests. For now, just use a migration
> > > > > > blocker so we get a meaningful error if someone attempts this (this is the
> > > > > > same approach used by AMD SEV).
> > > > > >
> > > > > > Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> > > > > > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > > > > > ---
> > > > > > hw/ppc/pef.c | 9 +++++++++
> > > > > > 1 file changed, 9 insertions(+)
> > > > > >
> > > > > > diff --git a/hw/ppc/pef.c b/hw/ppc/pef.c
> > > > > > index 3ae3059cfe..edc3e744ba 100644
> > > > > > --- a/hw/ppc/pef.c
> > > > > > +++ b/hw/ppc/pef.c
> > > > > > @@ -38,7 +38,11 @@ struct PefGuestState {
> > > > > > };
> > > > > >
> > > > > > #ifdef CONFIG_KVM
> > > > > > +static Error *pef_mig_blocker;
> > > > > > +
> > > > > > static int kvmppc_svm_init(Error **errp)
> > > > >
> > > > > This looks weird?
> > > >
> > > > Oops. Not sure how that made it past even my rudimentary compile
> > > > testing.
> > > >
> > > > > > +
> > > > > > +int kvmppc_svm_init(SecurableGuestMemory *sgm, Error **errp)
> > > > > > {
> > > > > > if (!kvm_check_extension(kvm_state, KVM_CAP_PPC_SECURABLE_GUEST)) {
> > > > > > error_setg(errp,
> > > > > > @@ -54,6 +58,11 @@ static int kvmppc_svm_init(Error **errp)
> > > > > > }
> > > > > > }
> > > > > >
> > > > > > + /* add migration blocker */
> > > > > > + error_setg(&pef_mig_blocker, "PEF: Migration is not implemented");
> > > > > > + /* NB: This can fail if --only-migratable is used */
> > > > > > + migrate_add_blocker(pef_mig_blocker, &error_fatal);
> > > > >
> > > > > Just so that I understand: is PEF something that is enabled by the host
> > > > > (and the guest is either secured or doesn't start), or is it using a
> > > > > model like s390x PV where the guest initiates the transition into
> > > > > secured mode?
> > > >
> > > > Like s390x PV it's initiated by the guest.
> > > >
> > > > > Asking because s390x adds the migration blocker only when the
> > > > > transition is actually happening (i.e. guests that do not transition
> > > > > into secure mode remain migratable.) This has the side effect that you
> > > > > might be able to start a machine with --only-migratable that
> > > > > transitions into a non-migratable machine via a guest action, if I'm
> > > > > not mistaken. Without the new object, I don't see a way to block with
> > > > > --only-migratable; with it, we should be able to do that. Not sure what
> > > > > the desirable behaviour is here.
> > > >
> >
> > The purpose of --only-migratable is specifically to prevent the machine
> > to transition to a non-migrate state IIUC. The guest transition to
> > secure mode should be nacked in this case.
>
> Yes, that's what happens for s390x: The guest tries to transition, QEMU
> can't add a migration blocker and fails the instruction used for
> transitioning, the guest sees the error.
>
> The drawback is that we see the failure only when we already launched
> the machine and the guest tries to transition. If I start QEMU with
> --only-migratable, it will refuse to start when non-migratable devices
> are configured in the command line, so I see the issue right from the
> start. (For s390x, that would possibly mean that we should not even
> present the cpu feature bit when only_migratable is set?)
I see --only-migratable as refusing to start if you've enabled anything
that would stop migration.
So I'd expect:
a) Allow the cpu flag to be turned on/off somehow
b) If you ask for it (-cpu ...,_confidentialcomp or whatever) and
you've got --only-migratable then you'd fail before startup.
Dave
> >
> > > > Hm, I'm not sure what the best option is here either.
> > >
> > > If we agree on anything, it should be as consistent across
> > > architectures as possible :)
> > >
> > > If we want to add the migration blocker to s390x even before the guest
> > > transitions, it needs to be tied to the new object; if we'd make it
> > > dependent on the cpu feature bit, we'd block migration of all machines
> > > on hardware with SE and a recent kernel.
> > >
> > > Is there a convenient point in time when PEF guests transition where
> > > QEMU can add a blocker?
> > >
> > > >
> > > > >
> > > > > > +
> > > > > > return 0;
> > > > > > }
> > > > > >
> > > > >
> > > >
> > >
> >
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2020-12-18 12:10 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 5:44 [for-6.0 v5 00/13] Generalize memory encryption models David Gibson
2020-12-04 5:44 ` [for-6.0 v5 01/13] qom: Allow optional sugar props David Gibson
2020-12-04 12:57 ` Cornelia Huck
2020-12-14 21:25 ` Eduardo Habkost
2021-01-11 18:04 ` Philippe Mathieu-Daudé
2020-12-04 5:44 ` [for-6.0 v5 02/13] securable guest memory: Introduce new securable guest memory base class David Gibson
2020-12-04 5:44 ` [for-6.0 v5 03/13] securable guest memory: Handle memory encryption via interface David Gibson
2020-12-04 13:10 ` Cornelia Huck
2021-01-08 4:03 ` David Gibson
2021-01-12 3:49 ` David Gibson
2020-12-04 5:44 ` [for-6.0 v5 04/13] securable guest memory: Move side effect out of machine_set_memory_encryption() David Gibson
2020-12-04 5:44 ` [for-6.0 v5 05/13] securable guest memory: Rework the "memory-encryption" property David Gibson
2021-01-11 18:09 ` Philippe Mathieu-Daudé
2020-12-04 5:44 ` [for-6.0 v5 06/13] securable guest memory: Decouple kvm_memcrypt_*() helpers from KVM David Gibson
2021-01-11 18:13 ` Philippe Mathieu-Daudé
2021-01-12 3:03 ` David Gibson
2020-12-04 5:44 ` [for-6.0 v5 07/13] sev: Add Error ** to sev_kvm_init() David Gibson
2020-12-14 16:50 ` Cornelia Huck
2020-12-04 5:44 ` [for-6.0 v5 08/13] securable guest memory: Introduce sgm "ready" flag David Gibson
2020-12-14 17:00 ` Cornelia Huck
2020-12-17 5:38 ` David Gibson
2020-12-17 11:24 ` Cornelia Huck
2020-12-04 5:44 ` [for-6.0 v5 09/13] securable guest memory: Move SEV initialization into arch specific code David Gibson
2020-12-04 5:44 ` [for-6.0 v5 10/13] spapr: Add PEF based securable guest memory David Gibson
2021-01-05 23:34 ` Ram Pai
2021-01-08 0:34 ` David Gibson
2020-12-04 5:44 ` [for-6.0 v5 11/13] spapr: PEF: prevent migration David Gibson
2020-12-14 17:22 ` Cornelia Huck
2020-12-17 5:47 ` David Gibson
2020-12-17 11:38 ` Cornelia Huck
2020-12-17 14:15 ` Greg Kurz
2020-12-18 11:41 ` Cornelia Huck
2020-12-18 12:08 ` Dr. David Alan Gilbert [this message]
2021-01-04 7:15 ` Ram Pai
2021-01-04 12:46 ` [EXTERNAL] " Halil Pasic
2021-01-04 18:40 ` Ram Pai
2021-01-05 10:56 ` [EXTERNAL] " Halil Pasic
2021-01-05 20:41 ` Ram Pai
2021-01-11 16:59 ` Cornelia Huck
2021-01-11 19:58 ` Ram Pai
2021-01-12 8:19 ` Cornelia Huck
2021-01-12 18:55 ` Ram Pai
2021-01-13 8:06 ` Cornelia Huck
2021-01-15 18:55 ` Ram Pai
2021-01-19 8:19 ` Cornelia Huck
2021-01-19 9:59 ` Daniel P. Berrangé
2021-01-14 11:23 ` Daniel P. Berrangé
2021-01-13 12:42 ` Dr. David Alan Gilbert
2021-01-14 10:28 ` Christian Borntraeger
2021-01-14 10:36 ` Dr. David Alan Gilbert
2021-01-14 10:52 ` Christian Borntraeger
2021-01-14 11:05 ` Cornelia Huck
2021-01-14 11:45 ` Dr. David Alan Gilbert
2021-01-14 11:50 ` Christian Borntraeger
2021-01-14 12:20 ` Daniel P. Berrangé
2021-01-14 14:04 ` Cornelia Huck
2021-01-14 14:09 ` Christian Borntraeger
2021-01-14 14:15 ` Daniel P. Berrangé
2021-01-14 15:25 ` Christian Borntraeger
2021-01-14 15:33 ` Daniel P. Berrangé
2021-01-15 18:24 ` Ram Pai
2021-01-14 11:25 ` Daniel P. Berrangé
2021-01-14 23:51 ` David Gibson
2021-01-18 17:39 ` Dr. David Alan Gilbert
2021-01-19 8:28 ` Christian Borntraeger
2021-01-19 8:34 ` Cornelia Huck
2020-12-04 5:44 ` [for-6.0 v5 12/13] securable guest memory: Alter virtio default properties for protected guests David Gibson
2020-12-04 8:10 ` Christian Borntraeger
2020-12-04 8:17 ` Cornelia Huck
2020-12-04 8:29 ` Christian Borntraeger
2020-12-04 14:43 ` Halil Pasic
2020-12-08 1:54 ` David Gibson
2020-12-08 8:16 ` Christian Borntraeger
2020-12-08 10:28 ` Halil Pasic
2020-12-08 12:50 ` Cornelia Huck
2020-12-17 5:53 ` David Gibson
2020-12-04 17:04 ` Cornelia Huck
2020-12-04 5:44 ` [for-6.0 v5 13/13] s390: Recognize securable-guest-memory option David Gibson
2020-12-15 11:45 ` Cornelia Huck
2020-12-17 5:54 ` David Gibson
2020-12-04 8:06 ` [for-6.0 v5 00/13] Generalize memory encryption models Christian Borntraeger
2020-12-04 13:02 ` Cornelia Huck
2020-12-04 13:07 ` Dr. David Alan Gilbert
2020-12-04 13:12 ` Cornelia Huck
2020-12-08 2:57 ` David Gibson
2020-12-08 12:43 ` Cornelia Huck
2020-12-17 6:21 ` David Gibson
2020-12-17 11:43 ` Cornelia Huck
2020-12-04 13:25 ` Daniel P. Berrangé
2020-12-04 13:51 ` Halil Pasic
2020-12-08 2:54 ` David Gibson
2020-12-04 9:50 ` Daniel P. Berrangé
2021-01-12 3:02 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201218120836.GA2956@work-vm \
--to=dgilbert@redhat.com \
--cc=berrange@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=brijesh.singh@amd.com \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=ehabkost@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=groug@kaod.org \
--cc=kvm@vger.kernel.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pair@us.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).