From: Keqian Zhu <zhukeqian1@huawei.com> To: <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <iommu@lists.linux-foundation.org>, <kvm@vger.kernel.org>, <kvmarm@lists.cs.columbia.edu>, Alex Williamson <alex.williamson@redhat.com>, Cornelia Huck <cohuck@redhat.com>, Will Deacon <will@kernel.org>, "Marc Zyngier" <maz@kernel.org>, Catalin Marinas <catalin.marinas@arm.com> Cc: Mark Rutland <mark.rutland@arm.com>, James Morse <james.morse@arm.com>, Robin Murphy <robin.murphy@arm.com>, Joerg Roedel <joro@8bytes.org>, "Daniel Lezcano" <daniel.lezcano@linaro.org>, Thomas Gleixner <tglx@linutronix.de>, Suzuki K Poulose <suzuki.poulose@arm.com>, Julien Thierry <julien.thierry.kdev@gmail.com>, Andrew Morton <akpm@linux-foundation.org>, Alexios Zavras <alexios.zavras@intel.com>, <wanghaibin.wang@huawei.com>, <jiangkunkun@huawei.com> Subject: [PATCH 3/6] vfio/iommu_type1: Initially set the pinned_page_dirty_scope Date: Thu, 7 Jan 2021 12:43:58 +0800 [thread overview] Message-ID: <20210107044401.19828-4-zhukeqian1@huawei.com> (raw) In-Reply-To: <20210107044401.19828-1-zhukeqian1@huawei.com> For now there are 3 ways to promote the pinned_page_dirty_scope status of vfio_iommu: 1. Through vfio pin interface. 2. Detach a group without pinned_dirty_scope. 3. Attach a group with pinned_dirty_scope. For point 3, the only chance to promote the pinned_page_dirty_scope status is when vfio_iommu is newly created. As we can safely set empty vfio_iommu to be at pinned status, then the point 3 can be removed to reduce operations. Signed-off-by: Keqian Zhu <zhukeqian1@huawei.com> --- drivers/vfio/vfio_iommu_type1.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c index 110ada24ee91..b596c482487b 100644 --- a/drivers/vfio/vfio_iommu_type1.c +++ b/drivers/vfio/vfio_iommu_type1.c @@ -2045,11 +2045,8 @@ static int vfio_iommu_type1_attach_group(void *iommu_data, * Non-iommu backed group cannot dirty memory directly, * it can only use interfaces that provide dirty * tracking. - * The iommu scope can only be promoted with the - * addition of a dirty tracking group. */ group->pinned_page_dirty_scope = true; - promote_pinned_page_dirty_scope(iommu); mutex_unlock(&iommu->lock); return 0; @@ -2436,6 +2433,7 @@ static void *vfio_iommu_type1_open(unsigned long arg) INIT_LIST_HEAD(&iommu->iova_list); iommu->dma_list = RB_ROOT; iommu->dma_avail = dma_entry_limit; + iommu->pinned_page_dirty_scope = true; mutex_init(&iommu->lock); BLOCKING_INIT_NOTIFIER_HEAD(&iommu->notifier); -- 2.19.1
next prev parent reply other threads:[~2021-01-07 4:45 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-07 4:43 [PATCH 0/6] vfio/iommu_type1: Some optimizations about dirty tracking Keqian Zhu 2021-01-07 4:43 ` [PATCH 1/6] vfio/iommu_type1: Make an explicit "promote" semantic Keqian Zhu 2021-01-15 22:42 ` Alex Williamson 2021-01-18 13:33 ` Keqian Zhu 2021-01-07 4:43 ` [PATCH 2/6] vfio/iommu_type1: Ignore external domain when promote pinned_scope Keqian Zhu 2021-01-15 23:23 ` Alex Williamson 2021-01-07 4:43 ` Keqian Zhu [this message] 2021-01-15 23:30 ` [PATCH 3/6] vfio/iommu_type1: Initially set the pinned_page_dirty_scope Alex Williamson 2021-01-18 13:34 ` Keqian Zhu 2021-01-07 4:43 ` [PATCH 4/6] vfio/iommu_type1: Drop parameter "pgsize" of vfio_dma_bitmap_alloc_all Keqian Zhu 2021-01-15 23:37 ` Alex Williamson 2021-01-07 4:44 ` [PATCH 5/6] vfio/iommu_type1: Drop parameter "pgsize" of vfio_iova_dirty_bitmap Keqian Zhu 2021-01-15 23:39 ` Alex Williamson 2021-01-07 4:44 ` [PATCH 6/6] vfio/iommu_type1: Drop parameter "pgsize" of update_user_bitmap Keqian Zhu 2021-01-15 23:44 ` Alex Williamson 2021-01-18 13:48 ` Keqian Zhu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210107044401.19828-4-zhukeqian1@huawei.com \ --to=zhukeqian1@huawei.com \ --cc=akpm@linux-foundation.org \ --cc=alex.williamson@redhat.com \ --cc=alexios.zavras@intel.com \ --cc=catalin.marinas@arm.com \ --cc=cohuck@redhat.com \ --cc=daniel.lezcano@linaro.org \ --cc=iommu@lists.linux-foundation.org \ --cc=james.morse@arm.com \ --cc=jiangkunkun@huawei.com \ --cc=joro@8bytes.org \ --cc=julien.thierry.kdev@gmail.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=maz@kernel.org \ --cc=robin.murphy@arm.com \ --cc=suzuki.poulose@arm.com \ --cc=tglx@linutronix.de \ --cc=wanghaibin.wang@huawei.com \ --cc=will@kernel.org \ --subject='Re: [PATCH 3/6] vfio/iommu_type1: Initially set the pinned_page_dirty_scope' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).