From: Yang Zhong <yang.zhong@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
tony.luck@intel.com, seanjc@google.com, vkuznets@redhat.com,
wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org,
kyung.min.park@intel.com, x86@kernel.org, yang.zhong@intel.com
Subject: Re: [PATCH 1/2] Enumerate AVX Vector Neural Network instructions
Date: Tue, 12 Jan 2021 10:13:21 +0800 [thread overview]
Message-ID: <20210112021321.GA9922@yangzhon-Virtual> (raw)
In-Reply-To: <20210105121456.GE28649@zn.tnic>
On Tue, Jan 05, 2021 at 01:14:56PM +0100, Borislav Petkov wrote:
> On Tue, Jan 05, 2021 at 12:47:23PM +0100, Paolo Bonzini wrote:
> > On 05/01/21 01:49, Yang Zhong wrote:
> > > From: Kyung Min Park <kyung.min.park@intel.com>
> > >
> > > Add AVX version of the Vector Neural Network (VNNI) Instructions.
> > >
> > > A processor supports AVX VNNI instructions if CPUID.0x07.0x1:EAX[4] is
> > > present. The following instructions are available when this feature is
> > > present.
> > > 1. VPDPBUS: Multiply and Add Unsigned and Signed Bytes
> > > 2. VPDPBUSDS: Multiply and Add Unsigned and Signed Bytes with Saturation
> > > 3. VPDPWSSD: Multiply and Add Signed Word Integers
> > > 4. VPDPWSSDS: Multiply and Add Signed Integers with Saturation
> > >
> > > The only in-kernel usage of this is kvm passthrough. The CPU feature
> > > flag is shown as "avx_vnni" in /proc/cpuinfo.
> > >
> > > This instruction is currently documented in the latest "extensions"
> > > manual (ISE). It will appear in the "main" manual (SDM) in the future.
> > >
> > > Signed-off-by: Kyung Min Park <kyung.min.park@intel.com>
> > > Signed-off-by: Yang Zhong <yang.zhong@intel.com>
> > > Reviewed-by: Tony Luck <tony.luck@intel.com>
> > > ---
> > > arch/x86/include/asm/cpufeatures.h | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h
> > > index f5ef2d5b9231..d10d9962bd9b 100644
> > > --- a/arch/x86/include/asm/cpufeatures.h
> > > +++ b/arch/x86/include/asm/cpufeatures.h
> > > @@ -293,6 +293,7 @@
> > > #define X86_FEATURE_PER_THREAD_MBA (11*32+ 7) /* "" Per-thread Memory Bandwidth Allocation */
> > > /* Intel-defined CPU features, CPUID level 0x00000007:1 (EAX), word 12 */
> > > +#define X86_FEATURE_AVX_VNNI (12*32+ 4) /* AVX VNNI instructions */
> > > #define X86_FEATURE_AVX512_BF16 (12*32+ 5) /* AVX512 BFLOAT16 instructions */
> > > /* AMD-defined CPU features, CPUID level 0x80000008 (EBX), word 13 */
> > >
> >
> > Boris, is it possible to have a topic branch for this patch?
>
> Just take it through your tree pls.
>
> Acked-by: Borislav Petkov <bp@suse.de>
>
Paolo, Boris has acked this kernel patch, and if i need send new patchset to add this
acked-by info ? or kvm tree will directly pull this patchset? thanks.
Yang
> Thx.
>
> --
> Regards/Gruss,
> Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-01-12 2:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 0:49 [PATCH 0/2] Enumerate and expose AVX_VNNI feature Yang Zhong
2021-01-05 0:49 ` [PATCH 1/2] Enumerate AVX Vector Neural Network instructions Yang Zhong
2021-01-05 11:47 ` Paolo Bonzini
2021-01-05 12:14 ` Borislav Petkov
2021-01-12 2:13 ` Yang Zhong [this message]
2021-01-13 12:54 ` Paolo Bonzini
2021-01-05 0:49 ` [PATCH 2/2] KVM: Expose AVX_VNNI instruction to guset Yang Zhong
2021-01-21 15:02 ` [PATCH 0/2] Enumerate and expose AVX_VNNI feature Paolo Bonzini
2021-01-22 6:43 ` Yang Zhong
-- strict thread matches above, loose matches on Subject: below --
2020-12-16 2:01 Yang Zhong
2020-12-16 2:01 ` [PATCH 1/2] Enumerate AVX Vector Neural Network instructions Yang Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210112021321.GA9922@yangzhon-Virtual \
--to=yang.zhong@intel.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=kyung.min.park@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).