From: Andrew Jones <drjones@redhat.com>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Shuah Khan <shuah@kernel.org>,
Sean Christopherson <seanjc@google.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>,
Igor Mammedov <imammedo@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] KVM: selftests: Keep track of memslots more efficiently
Date: Mon, 8 Feb 2021 11:20:27 +0100 [thread overview]
Message-ID: <20210208102027.roclkurxiibpx6su@kamzik.brq.redhat.com> (raw)
In-Reply-To: <20210208101634.vfsr6zoxjnrguwuv@kamzik.brq.redhat.com>
On Mon, Feb 08, 2021 at 11:16:41AM +0100, Andrew Jones wrote:
> > diff --git a/tools/testing/selftests/kvm/lib/rbtree.c b/tools/testing/selftests/kvm/lib/rbtree.c
> > new file mode 100644
> > index 000000000000..a703f0194ea3
> > --- /dev/null
> > +++ b/tools/testing/selftests/kvm/lib/rbtree.c
> > @@ -0,0 +1 @@
> > +#include "../../../../lib/rbtree.c"
> >
>
> We shouldn't dip into kernel code like this. We can use tools/lib/rbtree.c
> though.
>
> Besides the rbtree.c thing,
Oops, sorry, just realized the first '..' applies to kvm's lib subdir.
So this is already using tools/lib/rbtree.c
Thanks,
drew
>
> Reviewed-by: Andrew Jones <drjones@redhat.com>
prev parent reply other threads:[~2021-02-08 10:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 8:10 [PATCH 1/2] KVM: selftests: Keep track of memslots more efficiently Maciej S. Szmigiero
2021-02-01 8:10 ` [PATCH 2/2] KVM: selftests: add a memslot-related performance benchmark Maciej S. Szmigiero
2021-02-08 11:09 ` Andrew Jones
2021-02-08 10:16 ` [PATCH 1/2] KVM: selftests: Keep track of memslots more efficiently Andrew Jones
2021-02-08 10:20 ` Andrew Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210208102027.roclkurxiibpx6su@kamzik.brq.redhat.com \
--to=drjones@redhat.com \
--cc=imammedo@redhat.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).