From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: <cohuck@redhat.com>, <kvm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <peterx@redhat.com>
Subject: Re: [RFC PATCH 02/10] vfio: Update vfio_add_group_dev() API
Date: Mon, 22 Feb 2021 13:01:53 -0400 [thread overview]
Message-ID: <20210222170153.GN4247@nvidia.com> (raw)
In-Reply-To: <161401264735.16443.5908636631567017543.stgit@gimli.home>
On Mon, Feb 22, 2021 at 09:50:47AM -0700, Alex Williamson wrote:
> diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c
> index 464caef97aff..067cd843961c 100644
> +++ b/drivers/vfio/vfio.c
> @@ -848,8 +848,9 @@ static int vfio_iommu_group_notifier(struct notifier_block *nb,
> /**
> * VFIO driver API
> */
> -int vfio_add_group_dev(struct device *dev,
> - const struct vfio_device_ops *ops, void *device_data)
> +struct vfio_device *vfio_add_group_dev(struct device *dev,
> + const struct vfio_device_ops *ops,
> + void *device_data)
> {
> struct iommu_group *iommu_group;
> struct vfio_group *group;
> @@ -857,14 +858,14 @@ int vfio_add_group_dev(struct device *dev,
>
> iommu_group = iommu_group_get(dev);
> if (!iommu_group)
> - return -EINVAL;
> + return ERR_PTR(-EINVAL);
>
> group = vfio_group_get_from_iommu(iommu_group);
> if (!group) {
> group = vfio_create_group(iommu_group);
> if (IS_ERR(group)) {
> iommu_group_put(iommu_group);
> - return PTR_ERR(group);
> + return (struct vfio_device *)group;
Use ERR_CAST() here
Also, I've wrote a small series last week that goes further than this,
I made 'struct vfio_device *' the universal handle to refer to the
device, instead of using 'void *' or 'struct device *' as a surrogate.
It is interesting that you hit on the same issue as a blocker to this
series. So for I've found quite a few other things that are out of
sorts because of this.
Cheers,
Jason
next prev parent reply other threads:[~2021-02-22 17:02 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 16:50 [RFC PATCH 00/10] vfio: Device memory DMA mapping improvements Alex Williamson
2021-02-22 16:50 ` [RFC PATCH 01/10] vfio: Create vfio_fs_type with inode per device Alex Williamson
2021-02-26 5:38 ` Christoph Hellwig
2021-02-26 13:15 ` Jason Gunthorpe
2021-02-22 16:50 ` [RFC PATCH 02/10] vfio: Update vfio_add_group_dev() API Alex Williamson
2021-02-22 17:01 ` Jason Gunthorpe [this message]
2021-02-22 16:50 ` [RFC PATCH 03/10] vfio: Export unmap_mapping_range() wrapper Alex Williamson
2021-02-22 16:51 ` [RFC PATCH 04/10] vfio/pci: Use vfio_device_unmap_mapping_range() Alex Williamson
2021-02-22 17:22 ` Jason Gunthorpe
2021-02-24 21:55 ` Alex Williamson
2021-02-25 0:57 ` Jason Gunthorpe
2021-02-22 16:51 ` [RFC PATCH 05/10] vfio: Create a vfio_device from vma lookup Alex Williamson
2021-02-22 17:29 ` Jason Gunthorpe
2021-02-24 21:55 ` Alex Williamson
2021-02-25 0:06 ` Jason Gunthorpe
2021-02-25 22:21 ` Alex Williamson
2021-02-25 23:49 ` Jason Gunthorpe
2021-03-04 21:37 ` Alex Williamson
2021-03-04 23:16 ` Jason Gunthorpe
2021-03-05 0:07 ` Alex Williamson
2021-03-05 0:36 ` Jason Gunthorpe
2021-02-22 16:51 ` [RFC PATCH 06/10] vfio: Add a device notifier interface Alex Williamson
2021-02-22 16:51 ` [RFC PATCH 07/10] vfio/pci: Notify on device release Alex Williamson
2021-02-22 16:52 ` [RFC PATCH 08/10] vfio/type1: Refactor pfn_list clearing Alex Williamson
2021-02-22 16:52 ` [RFC PATCH 09/10] vfio/type1: Pass iommu and dma objects through to vaddr_get_pfn Alex Williamson
2021-02-22 16:52 ` [RFC PATCH 10/10] vfio/type1: Register device notifier Alex Williamson
2021-02-22 17:55 ` Jason Gunthorpe
2021-02-24 21:55 ` Alex Williamson
2021-02-25 0:22 ` Jason Gunthorpe
2021-02-25 17:54 ` Peter Xu
2021-02-25 18:19 ` Jason Gunthorpe
2021-02-25 19:06 ` Peter Xu
2021-02-25 19:17 ` Jason Gunthorpe
2021-02-25 19:54 ` Peter Xu
2021-02-26 5:47 ` Christoph Hellwig
2021-02-22 18:00 ` [RFC PATCH 00/10] vfio: Device memory DMA mapping improvements Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210222170153.GN4247@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).