From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A051C433B4 for ; Tue, 13 Apr 2021 13:47:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 24D2B6117A for ; Tue, 13 Apr 2021 13:47:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346123AbhDMNrs (ORCPT ); Tue, 13 Apr 2021 09:47:48 -0400 Received: from smtp-fw-6002.amazon.com ([52.95.49.90]:34854 "EHLO smtp-fw-6002.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346168AbhDMNrU (ORCPT ); Tue, 13 Apr 2021 09:47:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.de; i=@amazon.de; q=dns/txt; s=amazon201209; t=1618321621; x=1649857621; h=date:from:to:cc:message-id:references:mime-version: in-reply-to:subject; bh=zPB0tcxm7VsQe0IrZ2J3oFyEAOuY/wCfEhpeW5QXJ74=; b=UZRUI+YfbzlLhSbSasJSCIbjveL0IQAHhjTdQAAxBnjlxWEzyLr+tzjN OFLYiliwxgXYZYwQ9d4W+5HYzd+totio6F5z+sEQHE88qAheZNq4zn0CM 0kXWLpptMbGb54AgP504Poh9UHnlyW/WpStb/8CZFSdri6wFzpDVQm4+H M=; X-IronPort-AV: E=Sophos;i="5.82,219,1613433600"; d="scan'208";a="105754919" Subject: Re: [PATCH v2 1/4] KVM: x86: Move FPU register accessors into fpu.h Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-1a-821c648d.us-east-1.amazon.com) ([10.43.8.2]) by smtp-border-fw-out-6002.iad6.amazon.com with ESMTP; 13 Apr 2021 13:46:54 +0000 Received: from EX13D28EUC003.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-1a-821c648d.us-east-1.amazon.com (Postfix) with ESMTPS id 58567A1CEA; Tue, 13 Apr 2021 13:46:47 +0000 (UTC) Received: from uc8bbc9586ea454.ant.amazon.com (10.43.162.93) by EX13D28EUC003.ant.amazon.com (10.43.164.43) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 13 Apr 2021 13:46:38 +0000 Date: Tue, 13 Apr 2021 15:46:34 +0200 From: Siddharth Chandrasekaran To: Vitaly Kuznetsov CC: Alexander Graf , Evgeny Iakovlev , Liran Alon , Ioannis Aslanidis , , , , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Thomas Gleixner , Ingo Molnar , Borislav Petkov , , "H. Peter Anvin" , Paolo Bonzini , "Sean Christopherson" , Wanpeng Li , "Jim Mattson" , Joerg Roedel Message-ID: <20210413134634.GA27585@uc8bbc9586ea454.ant.amazon.com> References: <5d2945df9dd807dca45ab256c88aeb4430ecf508.1618244920.git.sidcha@amazon.de> <87y2dm5ml3.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <87y2dm5ml3.fsf@vitty.brq.redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [10.43.162.93] X-ClientProxiedBy: EX13D44UWB001.ant.amazon.com (10.43.161.32) To EX13D28EUC003.ant.amazon.com (10.43.164.43) Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Apr 13, 2021 at 03:40:56PM +0200, Vitaly Kuznetsov wrote: > Siddharth Chandrasekaran writes: > > @@ -0,0 +1,140 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > + > > +#ifndef __KVM_FPU_H_ > > +#define __KVM_FPU_H_ > > + > > +#include > > + > > +typedef u32 __attribute__((vector_size(16))) sse128_t; > > Post-patch we seem to have two definitions of 'sse128_t': > > $ git grep sse128_t > HEAD~3:arch/x86/kvm/fpu.h:typedef u32 __attribute__((vector_size(16))) sse128_t; > HEAD~3:arch/x86/kvm/fpu.h:#define __sse128_u union { sse128_t vec; u64 as_u64[2]; u32 as_u32[4]; } > HEAD~3:arch/x86/kvm/fpu.h:static inline void _kvm_read_sse_reg(int reg, sse128_t *data) > HEAD~3:arch/x86/kvm/fpu.h:static inline void _kvm_write_sse_reg(int reg, const sse128_t *data) > HEAD~3:arch/x86/kvm/fpu.h:static inline void kvm_read_sse_reg(int reg, sse128_t *data) > HEAD~3:arch/x86/kvm/fpu.h:static inline void kvm_write_sse_reg(int reg, const sse128_t *data) > HEAD~3:arch/x86/kvm/kvm_emulate.h:typedef u32 __attribute__((vector_size(16))) sse128_t; > HEAD~3:arch/x86/kvm/kvm_emulate.h: char valptr[sizeof(sse128_t)]; > HEAD~3:arch/x86/kvm/kvm_emulate.h: sse128_t vec_val; > > Should the one from kvm_emulate.h go away? Yes, removed. ~ Sid. Amazon Development Center Germany GmbH Krausenstr. 38 10117 Berlin Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B Sitz: Berlin Ust-ID: DE 289 237 879