From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Janosch Frank <frankja@linux.ibm.com>
Cc: kvm@vger.kernel.org, david@redhat.com, thuth@redhat.com,
cohuck@redhat.com
Subject: Re: [kvm-unit-tests PATCH] s390x: Fix vector stfle checks
Date: Mon, 3 May 2021 15:06:05 +0200 [thread overview]
Message-ID: <20210503150605.624311e2@ibm-vm> (raw)
In-Reply-To: <20210503124713.68975-1-frankja@linux.ibm.com>
On Mon, 3 May 2021 12:47:13 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:
> 134 is for bcd
> 135 is for the vector enhancements
>
> Not the other way around...
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> Suggested-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> ---
> s390x/vector.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/s390x/vector.c b/s390x/vector.c
> index d1b6a571..b052de55 100644
> --- a/s390x/vector.c
> +++ b/s390x/vector.c
> @@ -53,7 +53,7 @@ static void test_add(void)
> /* z14 vector extension test */
> static void test_ext1_nand(void)
> {
> - bool has_vext = test_facility(134);
> + bool has_vext = test_facility(135);
> static struct prm {
> __uint128_t a,b,c;
> } prm __attribute__((aligned(16)));
> @@ -79,7 +79,7 @@ static void test_ext1_nand(void)
> /* z14 bcd extension test */
> static void test_bcd_add(void)
> {
> - bool has_bcd = test_facility(135);
> + bool has_bcd = test_facility(134);
> static struct prm {
> __uint128_t a,b,c;
> } prm __attribute__((aligned(16)));
prev parent reply other threads:[~2021-05-03 13:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 12:47 [kvm-unit-tests PATCH] s390x: Fix vector stfle checks Janosch Frank
2021-05-03 12:52 ` David Hildenbrand
2021-05-03 12:54 ` Cornelia Huck
2021-05-03 13:06 ` Claudio Imbrenda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210503150605.624311e2@ibm-vm \
--to=imbrenda@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).