Re: [kvm-unit-tests PATCH 4/4] s390x: cpumodel: FMT2 SCLP implies test

[Claudio Imbrenda <imbrenda@linux.ibm.com>]

On Mon, 10 May 2021 15:00:15 +0000
Janosch Frank <frankja@linux.ibm.com> wrote:

> The sie facilities require sief2 to also be enabled, so lets check if
> that's the case.
> 
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>

Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>

I agree with David, you can fold this in the previous patch

> ---
>  s390x/cpumodel.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/s390x/cpumodel.c b/s390x/cpumodel.c
> index 619c3dc7..67bb6543 100644
> --- a/s390x/cpumodel.c
> +++ b/s390x/cpumodel.c
> @@ -56,12 +56,24 @@ static void test_sclp_features_fmt4(void)
>  	report_prefix_pop();
>  }
>  
> +static void test_sclp_features_fmt2(void)
> +{
> +	if (sclp_facilities.has_sief2)
> +		return;
> +
> +	report_prefix_push("!sief2 implies");
> +	test_sclp_missing_sief2_implications();
> +	report_prefix_pop();
> +}
> +
>  static void test_sclp_features(void)
>  {
>  	report_prefix_push("sclp");
>  
>  	if (uv_os_is_guest())
>  		test_sclp_features_fmt4();
> +	else
> +		test_sclp_features_fmt2();
>  
>  	report_prefix_pop();
>  }